Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Failing tests by upgrading Parse Server version #503

Merged
merged 4 commits into from
May 12, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 28, 2023

New Pull Request Checklist

Issue Description

Closes: #502

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add changelog entry

@parse-github-assistant
Copy link

parse-github-assistant bot commented Apr 28, 2023

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (eedefb9) 98.60% compared to head (bceaa9d) 98.60%.

❗ Current head bceaa9d differs from pull request most recent head c2cd71b. Consider uploading reports for the commit c2cd71b to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #503   +/-   ##
=========================================
  Coverage     98.60%   98.60%           
  Complexity     1062     1062           
=========================================
  Files            38       38           
  Lines          3229     3229           
=========================================
  Hits           3184     3184           
  Misses           45       45           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dplewis dplewis requested a review from mtrezza May 12, 2023 17:52
@dplewis
Copy link
Member Author

dplewis commented May 12, 2023

@mtrezza The tests pass now, this can be merged

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title test: Failing test for #502 test: Failing tests by upgrading Parse Server version May 12, 2023
@mtrezza mtrezza merged commit 77b06f4 into parse-community:master May 12, 2023
@dplewis dplewis deleted the failing-test-502 branch May 12, 2023 18:36
@parseplatformorg
Copy link

🎉 This change has been released in version 2.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version Edit label May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version Edit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SaveAll on new objects does not return objectIds
3 participants