Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Bump firebase-admin from 12.7.0 to 13.0.1 #332

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 21, 2024

Bumps firebase-admin from 12.7.0 to 13.0.1.

Release notes

Sourced from firebase-admin's releases.

Firebase Admin Node.js SDK v13.0.1

Bug Fixes

  • fix: Fix the property names when initializing the SDK with ServiceAccount type (#2779)

Miscellaneous

  • [chore] Release 13.0.1 (#2780)
  • build(deps-dev): bump @​firebase/auth-compat from 0.5.15 to 0.5.16 (#2776)
  • build(deps): bump google-auth-library from 9.14.2 to 9.15.0 (#2773)
  • build(deps): bump @​firebase/database-compat from 2.0.0 to 2.0.1 (#2774)
  • build(deps-dev): bump @​firebase/auth-types from 0.12.2 to 0.12.3 (#2775)

Firebase Admin Node.js SDK v13.0.0

Breaking Changes

  • change(rc): Update Remote Config condition evaluation hashing (#2760)
  • change(fcm): Remove deprecated FCM APIs (#2759)
  • change: Update Node support to 18 (#2756)
  • change: Migrate credentials to use google-auth-library (#2466)

New Features

  • feat(fcm): Add directBootOk field to AndroidConfig (#2745)

Bug Fixes

  • fix: Set the Quota Project ID only for ADC human accounts (#2761)

Miscellaneous

  • [chore] Release 13.0.0 (#2764)
  • build(deps): bump uuid from 11.0.2 to 11.0.3 (#2767)
  • build(deps-dev): bump nock from 13.5.5 to 13.5.6 (#2766)
  • chore: Add X-Goog-Api-Client metric header to outgoing authorized http requests (#2763)
  • chore: Upgrade dependencies (#2757)
  • Request timeout const name correction (#2743)
  • build(deps-dev): bump @​firebase/app-compat from 0.2.43 to 0.2.45 (#2746)
Commits
  • 90a8e5e [chore] Release 13.0.1 (#2780)
  • ef8b701 build(deps-dev): bump @​firebase/auth-compat from 0.5.15 to 0.5.16 (#2776)
  • cc78a4a build(deps): bump google-auth-library from 9.14.2 to 9.15.0 (#2773)
  • 7249cd3 build(deps): bump @​firebase/database-compat from 2.0.0 to 2.0.1 (#2774)
  • 2b6a373 build(deps-dev): bump @​firebase/auth-types from 0.12.2 to 0.12.3 (#2775)
  • 380ef0a fix: Fix the property names when initializing the SDK with ServiceAccount typ...
  • a6a930c [chore] Release 13.0.0 (#2764)
  • 8b978e0 build(deps): bump uuid from 11.0.2 to 11.0.3 (#2767)
  • 49a8e0b build(deps-dev): bump nock from 13.5.5 to 13.5.6 (#2766)
  • 4ee1bb2 fix: Set the Quota Project ID only for ADC human accounts (#2761)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 21, 2024
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title refactor: bump firebase-admin from 12.7.0 to 13.0.1 refactor: Bump firebase-admin from 12.7.0 to 13.0.1 Nov 21, 2024
@mtrezza mtrezza closed this Nov 21, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 21, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@mtrezza mtrezza reopened this Nov 21, 2024
Copy link

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@mtrezza
Copy link
Member

mtrezza commented Nov 21, 2024

Can we just merge this?

Breaking changes:

  1. change(rc): Update Remote Config condition evaluation hashing (#2760) --> ?
  2. change(fcm): Remove deprecated FCM APIs (#2759) --> deprecated code we can remove in the adapter?
  3. change: Update Node support to 18 (#2756) --> ok, adapter already requires node >= 18
  4. change: Migrate credentials to use google-auth-library (#2466) --> is this impacting developers? does it require different adapter options or code change in adapter?

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/firebase-admin-13.0.1 branch 3 times, most recently from bf2d6b7 to 6b20944 Compare December 4, 2024 01:44
@mtrezza mtrezza linked an issue Dec 4, 2024 that may be closed by this pull request
3 tasks
@mtrezza mtrezza removed a link to an issue Dec 4, 2024
3 tasks
@mtrezza mtrezza linked an issue Dec 4, 2024 that may be closed by this pull request
3 tasks
@mtrezza mtrezza mentioned this pull request Dec 4, 2024
3 tasks
Bumps [firebase-admin](https://github.com/firebase/firebase-admin-node) from 12.7.0 to 13.0.1.
- [Release notes](https://github.com/firebase/firebase-admin-node/releases)
- [Changelog](https://github.com/firebase/firebase-admin-node/blob/master/CHANGELOG.md)
- [Commits](firebase/firebase-admin-node@v12.7.0...v13.0.1)

---
updated-dependencies:
- dependency-name: firebase-admin
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/firebase-admin-13.0.1 branch from 6b20944 to 7c92f2b Compare December 4, 2024 01:51
@mtrezza
Copy link
Member

mtrezza commented Dec 8, 2024

@mman, would you like to take a look at this? All the tests pass, but I'm not sure in this case, see #332 (comment).

@mman
Copy link
Contributor

mman commented Dec 10, 2024

@mtrezza I'm not familiar with firebase admin at all, but I guess I can try to bump it and run it in my limited staging environment to see whether everything works...

@mtrezza
Copy link
Member

mtrezza commented Dec 10, 2024

Sorry, I thought you were familiar with it from the work you did in #238. I guess if you could upgrade it and try it out, that would help! Maybe @jimnor0xF could advise us on (2) in #332 (comment), since he did the FCM API v2 upgrade; does that mean we can remove the fcmEnableLegacyHttpTransport option?

@jimnor0xF
Copy link
Contributor

@mtrezza
We only use sendEachForMulticast which is not included in that list. The fcmEnableLegacyHttpTransport option is not related to these removals.

This option just allows you to use http1 as transport for the newer APIs like sendEachForMulticast or sendEach. AFAIK, they will remove this option at some point when the http2 transport they added is battle tested enough. It's not in this release though.

@mtrezza
Copy link
Member

mtrezza commented Dec 11, 2024

Thanks for clarifying, so we should be good to upgrade I guess. The firebase-admin release notes also don't show anything suspicious.

@mtrezza mtrezza merged commit 5409e48 into master Dec 11, 2024
5 of 6 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/firebase-admin-13.0.1 branch December 11, 2024 16:47
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file state:released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to firebase-admin 13.x
4 participants