Better typing of QueryOptions

parse-community · Nov 14, 2017 · 34a4d27 · 34a4d27
1 parent f238f95
commit 34a4d27
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/Adapters/Storage/Mongo/MongoStorageAdapter.js b/src/Adapters/Storage/Mongo/MongoStorageAdapter.js
@@ -16,13 +16,13 @@ import {
   transformWhere,
   transformUpdate,
 } from './MongoTransform';
-// $FlowFixMe
+// @flow-disable-next
 import Parse                 from 'parse/node';
-// $FlowFixMe
+// @flow-disable-next
 import _                     from 'lodash';
 import defaults              from '../../../defaults';
 
-// $FlowFixMe
+// @flow-disable-next
 const mongodb = require('mongodb');
 const MongoClient = mongodb.MongoClient;
 const ReadPreference = mongodb.ReadPreference;
@@ -93,7 +93,7 @@ export class MongoStorageAdapter implements StorageAdapter, IndexingStorageAdapt
   _collectionPrefix: string;
   _mongoOptions: Object;
   // Public
-  connectionPromise;
+  connectionPromise: Promise<any>;
   database: any;
   _maxTimeMS: ?number;
   canSortOnJoinTables: boolean;
@@ -439,7 +439,7 @@ export class MongoStorageAdapter implements StorageAdapter, IndexingStorageAdapt
   }
 
   _parseReadPreference(readPreference: ?string): ?string {
-    if (readPreference) {
+    if (readPreference != null) {
       switch (readPreference) {
       case 'PRIMARY':
         readPreference = ReadPreference.PRIMARY;

diff --git a/src/Adapters/Storage/StorageAdapter.js b/src/Adapters/Storage/StorageAdapter.js
@@ -3,11 +3,11 @@ export type SchemaType = any;
 export type StorageClass = any;
 export type QueryType = any;
 export type QueryOptionsType = {
-  skip?: number;
-  limit?: number;
-  sort?: any;
-  keys?: string[];
-  readPreference?: string;
+  skip?: ?number;
+  limit?: ?number;
+  sort?: ?any;
+  keys?: ?string[];
+  readPreference?: ?string;
 };
 
 export interface StorageAdapter {