Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable direct access by default #6637

Closed
1 task
mtrezza opened this issue Apr 23, 2020 · 7 comments
Closed
1 task

Enable direct access by default #6637

mtrezza opened this issue Apr 23, 2020 · 7 comments

Comments

@mtrezza
Copy link
Member

mtrezza commented Apr 23, 2020

Is your feature request related to a problem? Please describe.

  • Direct access of Parse Server within Cloud Code is feature flagged for some time.
  • It is used in production environments by some without feedback of any major issues.
  • Given the potential for significant performance improvement for Parse Server deployments without any code changes necessary, it would be beneficial to move it out of its experimental state and enable it by default.

Describe the solution you'd like
Identify any issues, remove the feature flag, maybe enable by default, see #6637 (comment).

Additional context

Related PRs

Related discussions

@mtrezza mtrezza changed the title Enable direct access as default Enable direct access by default Apr 23, 2020
@mtrezza
Copy link
Member Author

mtrezza commented Apr 23, 2020

As quick performance test for directAccess here is a load test for a _User query by objectId:

response time status quo direct access
avg. 193.02ms 64.69ms
min 9ms 9ms
p95 459ms 279ms
p99 611ms 427ms

This shows that it's well worth pursuing this feature.

@dplewis
Copy link
Member

dplewis commented Apr 23, 2020

Check out #6636 (comment)

@mtrezza
Copy link
Member Author

mtrezza commented May 30, 2020

In a previous series of load testing, we realized that JSON serialization of large objects was a large source of CPU consumption, and was inducing latency in the responses as serialization is blocking the node process.

In our case, we decided not to go with the direct access but to let internal cloud code calls reach another server, as it was the most optimal solution for our workload

This means that enabling directAccess by default can be a breaking change as described in #4658 (comment), so maybe it should be disabled by default?

@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Jul 18, 2020
@stale
Copy link

stale bot commented Sep 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 2, 2020
@stale stale bot closed this as completed Sep 11, 2020
@mtrezza mtrezza reopened this Apr 5, 2021
@mtrezza
Copy link
Member Author

mtrezza commented Apr 5, 2021

Closed by #6636

@mtrezza mtrezza closed this as completed Apr 5, 2021
@gtzinos
Copy link

gtzinos commented Nov 11, 2022

Anyone we found a way to deal with undefined values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants