Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use public server url as alternative for mount #1270

Closed
wants to merge 1 commit into from
Closed

use public server url as alternative for mount #1270

wants to merge 1 commit into from

Conversation

euklid
Copy link

@euklid euklid commented Mar 30, 2016

refs #905 and refs #1131 and tries to follow the instructions in #905. For our setup it works.
This supports the solution with the mentioned usage of X-Forwarded-Proto headers or, if given, uses the public server url to create correct links for the files behind a proxy, even without the need to set the 'trust proxy' option in express.

@euklid
Copy link
Author

euklid commented Mar 30, 2016

unfortunately I have to admit that I don't really know why the response is undefined (probably something to do with the change in RestWrite.js ) in the test and any advise would be a great help. I myself am not very familiar with JavaScript development...

@flovilmart
Copy link
Contributor

@euklid we should keep config.mount as it's used by external modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants