Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: session validation fails because the default session schema expects date not iso string #135

Conversation

gnz00
Copy link

@gnz00 gnz00 commented Feb 1, 2016

Fixes the last comment on #85 and #94

Signed-off-by: Alexander Mays maysale01@gmail.com

@gnz00 gnz00 changed the title Bugfix: Correctly passes ParseDate rather than iso string when creating a new session Bugfix: session validation fails because the default session schema expects date not iso string Feb 1, 2016
Converts httpRequest body to string if needed
…validation-fails-if-installation-id-is-undefined

Bugfix: session validation fails if the request does not include installationId
@gfosco
Copy link
Contributor

gfosco commented Feb 1, 2016

Please rebase and I'll merge, thanks! 👍

felixrieseberg and others added 14 commits February 1, 2016 10:30
- This commit replaces bcrypt with bcrypt-node, which has the same functionality as bcrypy - except that it is a pure Node implementation. This change is required to run parse-server on Windows (one can get bcrypt to compile on Windows, but it requires a few Gigabytes of dependencies).
Add Windows Support (bcrypt > bcrypt-node)
Addressed bugs with bcrypt-nodejs and changed crypto.js to password.js
Added multi-app support in DatabaseAdapter.js
Adding CONTRIBUTING.md and Open Code of Conduct.
Add support for saving files to AWS S3
… new session

Signed-off-by: Alexander Mays <maysale01@gmail.com>
Signed-off-by: Alexander Mays <maysale01@gmail.com>
@gnz00
Copy link
Author

gnz00 commented Feb 1, 2016

Rebased it, but had to add an extra commit. Not sure what's up with my gitfu.

@gfosco
Copy link
Contributor

gfosco commented Feb 1, 2016

This is quite a strange PR now after rebasing... Can you ... start from master and re-submit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants