Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1568 #1574

Merged
merged 1 commit into from
Apr 20, 2016
Merged

Fixes #1568 #1574

merged 1 commit into from
Apr 20, 2016

Conversation

drew-gross
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Current coverage is 92.95%

Merging #1574 into master will increase coverage by +0.11% as of a5c275b

@@            master   #1574   diff @@
======================================
  Files           87      87       
  Stmts         5520    5520       
  Branches      1031    1031       
  Methods          0       0       
======================================
+ Hit           5125    5131     +6
  Partial         10      10       
+ Missed         385     379     -6

Review entire Coverage Diff as of a5c275b

Powered by Codecov. Updated on successful CI builds.

@@ -112,13 +112,14 @@ DatabaseController.prototype.untransformObject = function(
return object;
}

delete object.authData;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont we want to do the same to the sessionToken? May need to check against Parse.com?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the whole reason for the change in the first place was to strip out legacy session tokens where they still exist in the DB?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm... Right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants