FIX #1572 - Accepting LOGS_FOLDER as env variable #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Thanks for the PR! We mostly use a convention of prefixing our env vars with |
|
Hi, Will make the changes. A Note in /wiki/Parse-Server-Guide will be good to go or should it be in any other docs? |
|
@KartikeyaRokde updated the pull request. |
Current coverage is 92.26%@@ master #1757 diff @@
==========================================
Files 87 87
Lines 6201 6202 +1
Methods 1070 1070
Messages 0 0
Branches 1289 1290 +1
==========================================
+ Hits 5721 5722 +1
Misses 480 480
Partials 0 0
|
|
@KartikeyaRokde updated the pull request. |
|
Hi Team, there's Mongo authentication error for all the CI builds for Node.js: 6.1 and MONGODB_VERSION=3.0.8. ``
I think the mongoDB is not configured with authentication. Can you please have a look in this. |
|
I restarted the build and it passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue #1572
Accepting LOGS_FOLDER from environment variable will help developers to set logs folder as they require.