Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting, applied sensible styles to the existing files, moved the source files to a src directory #176

Closed
wants to merge 2 commits into from

Conversation

gnz00
Copy link

@gnz00 gnz00 commented Feb 2, 2016

Figured we would need to align behind a single style guide. I've applied these defaults to the whole src directory:

module.exports = {
    "rules": {
        "indent": [
            2,
            4
        ],
        "quotes": [
            2,
            "single"
        ],
        "linebreak-style": [
            2,
            "unix"
        ],
        "semi": [
            2,
            "always"
        ]
    },
    "env": {
        "es6": true,
        "node": true,
        "jasmine": true,
    },
    "extends": "eslint:recommended"
};

Alexander Mays added 2 commits February 2, 2016 09:12
Signed-off-by: Alexander Mays <maysale01@gmail.com>
Signed-off-by: Alexander Mays <maysale01@gmail.com>
@steven-supersolid
Copy link
Contributor

Suggest matching the existing style in this PR. There is also an open issue for restructuring the file layout: #155 so might be better to make a separate PR for the file move too.

@gnz00
Copy link
Author

gnz00 commented Feb 2, 2016

@steven-supersolid Well, the issue for restructuring is open for discussion and I'm not sure it'll be actionable any time soon. This was more so an actionable PR, and I don't think they conflict. Which existing style are you referring to?

@steven-supersolid
Copy link
Contributor

I believe this PR changes the style of code on master, e.g. the indent goes from 2 to 4 characters. It's hard to see because of the file move so I may be wrong on this. classes.js seems to have gained extra indentation for example.
If file moves are done in a separate PR then hopefully the github 'files changed' will just display path changes for that PR or is that not the case?

@gfosco
Copy link
Contributor

gfosco commented Feb 2, 2016

I want to accept this, but I don't think right now is the time. We need to focus on bug fixes and feature parity, and when things are stabilized we can restructure and pretty up the repo. I'm going to close both of these issues for now, and let's revisit later. Sorry! Please hang in there.

Also, yeah, indents should be 2 spaces always according to our style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants