Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a test demonstrating issue #1840. #1940

Conversation

airdrummingfool
Copy link
Contributor

@airdrummingfool airdrummingfool commented May 29, 2016

This test demonstrates #1840: using unset to remove a child object leaves behind an UnsetOp in the child object's place when there is a non-trivial beforeSave on the parent object.

@flovilmart
Copy link
Contributor

Awesome! Any clue for a fix proposal?

@airdrummingfool
Copy link
Contributor Author

No ideas yet - if I get some time in the next couple of days I'll do some digging.

@airdrummingfool
Copy link
Contributor Author

airdrummingfool commented May 29, 2016

@flovilmart I found another bug that is related, but is exposed using set('key', undefined) instead of unset('key') and has a different outcome. Is it more appropriate to add it to this existing test, or write a new test?
EDIT: went ahead and added it as a separate test in #1943.

@flovilmart
Copy link
Contributor

Closing as we have a fix with Parse-JS 1.9

@flovilmart flovilmart closed this Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants