Move transform acl #2021
Merged
Move transform acl #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the database adapters, it will be more performant and easier to work with _rperm and _wperm than with the ACL object. This way we can type it as an array and so on, and once we have stronger validations in Parse Server, we can type it as an array containing strings of length < x, which will be much much better in sql databases.
ghost
added
the
Current coverage is 91.98%
@@ master #2021 diff @@
==========================================
Files 91 91
Lines 6431 6434 +3
Methods 1099 1099
Messages 0 0
Branches 1350 1355 +5
==========================================
+ Hits 5912 5918 +6
+ Misses 519 516 -3
Partials 0 0
|
Merged
| } | ||
| }); | ||
| }); | ||
| }); | ||
| }; | ||
|
|
||
| // Transforms a Database format ACL to a REST API format ACL |
There was a problem hiding this comment.
I'd put that method alongside the transformCounter part for readability
|
LGTM after the small nit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the database adapters, it will be more performant and easier to work with _rperm and _wperm than with the ACL object. This way we can type it as an array and so on, and once we have stronger validations in Parse Server, we can type it as an array containing strings of length < x, which will be much much better for sql databases.