Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed extra /logout handler #254

Merged
merged 3 commits into from
Feb 11, 2016
Merged

Removed extra /logout handler #254

merged 3 commits into from
Feb 11, 2016

Conversation

gfosco
Copy link
Contributor

@gfosco gfosco commented Feb 5, 2016

No description provided.

@gfosco gfosco mentioned this pull request Feb 5, 2016
Closed
@nlutsenko nlutsenko assigned gfosco and unassigned nlutsenko Feb 5, 2016
@drew-gross
Copy link
Contributor

Why delete this one? The other one does less error handling.

@gfosco
Copy link
Contributor Author

gfosco commented Feb 6, 2016

Logout shouldn't fail. This one silently succeeds always and I believe that to be the correct approach.

@drew-gross
Copy link
Contributor

No the other one doesn't silently succeed if, for example, the database can't be reached.

@facebook-github-bot
Copy link

@gfosco updated the pull request.

@drew-gross
Copy link
Contributor

Cool. I would like to see some tests for this one as it's a security issue. (imagine a user logs thinks they have logged out from a public computer, but really the next person to use the computer can still log in as them)

Hopefully we can avoid having to make any CVEs for quite awhile :)

This was referenced Feb 10, 2016
Closed
Closed
@facebook-github-bot
Copy link

@gfosco updated the pull request.

@gfosco gfosco assigned drew-gross and unassigned gfosco Feb 10, 2016
@drew-gross
Copy link
Contributor

Yay passing tests!

gfosco added a commit that referenced this pull request Feb 11, 2016
@gfosco
Merge pull request #254 from ParsePlatform/fosco.logout
8d89838 
Removed extra /logout handler
@gfosco gfosco merged commit 8d89838 into master Feb 11, 2016
@gfosco gfosco deleted the fosco.logout branch February 11, 2016 00:52
@gfosco gfosco mentioned this pull request Feb 11, 2016
Closed
@woodardj
Copy link

We're observing this code now always deleting the most recently created _Session. How do we call Parse.User.logout() and specify which session we want to delete?

@adambarghouthi
Copy link

@woodardj were you able to figure it out? I'm having the same problem

@snyk-bot snyk-bot mentioned this pull request Feb 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@drew-gross drew-gross

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gfosco @drew-gross @facebook-github-bot @woodardj @adambarghouthi @nlutsenko