Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve update of jsonb fields. Add PG 9.5 to travis. #2984

Merged
merged 2 commits into from
Nov 2, 2016

Conversation

kulshekhar
Copy link
Contributor

This PR changes the travis config and updates of jsonb fields in the following manner:

Travis:

  • use Postgres 9.5
  • set sudo to required
  • replace the precise distribution with trusty

The last two changes are required because Travis doesn't seem to have a simple way of using Postgres 9.5 with precise (with or without sudo) and it needs sudo on trusty

Update of jsonb fields

  • for a normal update, the new object is merged with the existing object
  • for an update that specifies field(s) should be deleted, the update deletes the specified fields and merges the rest of the object.

This PR also enables one existing test to run against Postgres

@flovilmart
Copy link
Contributor

You're on fire!

@kulshekhar
Copy link
Contributor Author

Given that the alternative would be to build something eerily similar to parse server (using postgres instead of mongodb), I'm just trying to do what I can to make parse server work with Postgres 😄

@flovilmart
Copy link
Contributor

Eheh the bases are pretty solid! Thanks for all your contributions and the ones to come!

@facebook-github-bot
Copy link

@kulshekhar updated the pull request - view changes

1 similar comment
@facebook-github-bot
Copy link

@kulshekhar updated the pull request - view changes

@flovilmart
Copy link
Contributor

tests seem to fail on travis but I can't see the logs :/

@kulshekhar
Copy link
Contributor Author

same here. It's happening with some other repos too.

@kulshekhar
Copy link
Contributor Author

For the postgres specific builds that fail, it's a bit weird. If it doesn't fail on both 4.5 and 6.1, chances are that rebuilding the test for the failed version will pass

@flovilmart
Copy link
Contributor

Looking 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants