-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/3678 overloaded query constraints #3723
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3723 +/- ##
==========================================
- Coverage 90.22% 90.21% -0.02%
==========================================
Files 114 114
Lines 7461 7491 +30
==========================================
+ Hits 6732 6758 +26
- Misses 729 733 +4
Continue to review full report at Codecov.
|
4bbbb8d
to
b5592ed
Compare
src/RestQuery.js
Outdated
let hasDirectConstraint = false; | ||
let hasOperatorConstraint = false; | ||
for (const key in constraint) { | ||
if (key.indexOf('$') != 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!==
Fixes #3678
Having 2 constraints on the same key when a pointer is set will yield an odd where constraint:
this PR transforms the constraint to:
In order to be correctly processed.
We should also probably investigate why this happens in the 1st place, the JS SDK handles this in a very odd way.