Update CONTRIBUTING.md #3873
Update CONTRIBUTING.md #3873
Conversation
CONTRIBUTING.md
Outdated
|
|
||
| If your pull request introduces a change that may affect the storage or retrieval of objects, you may want to make sure it plays nice with Postgres. | ||
|
|
||
| * Run the tests against the postgres database with `PARSE_SERVER_TEST_DB=postgres npm test`. You'll need to have postgres running on your machine an setup [appropriatedly](https://github.com/parse-community/parse-server/blob/master/.travis.yml#L37) |
There was a problem hiding this comment.
machine an setup - misspelling.
CONTRIBUTING.md
Outdated
| If your pull request introduces a change that may affect the storage or retrieval of objects, you may want to make sure it plays nice with Postgres. | ||
|
|
||
| * Run the tests against the postgres database with `PARSE_SERVER_TEST_DB=postgres npm test`. You'll need to have postgres running on your machine an setup [appropriatedly](https://github.com/parse-community/parse-server/blob/master/.travis.yml#L37) | ||
| * If your feature is a mongoDB only feature and the test don't apply for a Postgres database, you can disable them with: |
There was a problem hiding this comment.
If your feature is a mongoDB only feature and the test don't apply for a Postgres database, you can disable them with:
Incorrect English all the way.
There was a problem hiding this comment.
Something like this -
If you only use MongoDB, you should disable PostgreSQL-specific tests with:
There was a problem hiding this comment.
Or, if your feature is specific to MongoDB, ...
Codecov Report
@@ Coverage Diff @@
## master #3873 +/- ##
=========================================
Coverage ? 90.22%
=========================================
Files ? 114
Lines ? 7571
Branches ? 0
=========================================
Hits ? 6831
Misses ? 740
Partials ? 0Continue to review full report at Codecov.
|
No description provided.