Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test #3876

Merged
merged 2 commits into from
May 29, 2017
Merged

Conversation

flovilmart
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 28, 2017

Codecov Report

Merging #3876 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3876      +/-   ##
==========================================
- Coverage   90.26%   90.25%   -0.02%     
==========================================
  Files         114      114              
  Lines        7574     7574              
==========================================
- Hits         6837     6836       -1     
- Misses        737      738       +1
Impacted Files Coverage Δ
src/rest.js 97.01% <0%> (-1.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57efd89...4af2cea. Read the comment docs.

@flovilmart
Copy link
Contributor Author

flovilmart commented May 28, 2017

Seems that the PUT / GET is getting delayed for some reason (see log)

PUT 1496007166093 hello world
GET 1496007166127 hello { value: 'world',
  expire: 1496007166104,

So the key has expired way before the get occurs. Not sure why this happen.

@flovilmart flovilmart force-pushed the investigate-in-memory-cache-problem branch from 9c645a8 to 81ca86f Compare May 28, 2017 21:49
- Parse.User.logOut is async and was making a test flaky
@flovilmart flovilmart force-pushed the investigate-in-memory-cache-problem branch from a0d0520 to 4af2cea Compare May 28, 2017 23:43
@flovilmart flovilmart merged commit 73aafa2 into master May 29, 2017
@flovilmart flovilmart deleted the investigate-in-memory-cache-problem branch May 29, 2017 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants