Update request-promise to the latest version 🚀 #4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #4200 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 116 116
Lines 8091 8091
=======================================
Hits 7462 7462
Misses 629 629
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 4.2.2 of request-promise just got published.
The version 4.2.2 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of request-promise.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 13 commits.
afaa3e6Version 4.2.2894672dMerge pull request #226 from rouanw/upgrade_tough_cookie558729bfix: make sure to have only one tough-cookie installationfb058fefix: using latest allowed request version for old node.js environments60ba4ebfix: using latest allowed request version for old node.js environments672cb28upgrade tough-cookie to a version without regex DoS vulnerability3c2c53cMerge pull request #216 from Syrok/patch-1001af69Fixed mispell in doce882d03docs: comment regarding exposing of methods5261ff4docs: tabs to spaces32d9473docs: polished form data example662c81aMerge pull request #207 from erf/formData6323753fix and improve formData exampleSee the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴