-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add default Cache-Control header to files router #4348
Changes from 1 commit
bfa5375
2223bb0
1b58e8f
d421d0d
363e733
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -137,7 +137,8 @@ module.exports.ParseServerOptions = { | |
}, | ||
"filesCacheControl": { | ||
"env": "PARSE_SERVER_FILES_CACHE_CONTROL", | ||
"help": "Cache-Control header for files router" | ||
"help": "Cache-Control header for files router", | ||
"default": "public, max-age=86400" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we want a default value here. Changing expected behavior by introducing caching would cause unexpected issues if someone needed to update their file within that 24 hr period. It would be best if it was unset as it was before. |
||
}, | ||
"userSensitiveFields": { | ||
"env": "PARSE_SERVER_USER_SENSITIVE_FIELDS", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,7 +65,7 @@ export interface ParseServerOptions { | |
/* Key for your files */ | ||
fileKey: ?string; | ||
/* Cache-Control header for files router */ | ||
filesCacheControl: ?string; | ||
filesCacheControl: ?string; // = public, max-age=86400 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, if we drop the default we'll want to remove this comment. |
||
/* Personally identifiable information fields in the user table the should be removed for non-authorized users. */ | ||
userSensitiveFields: ?string[]; // = ["email"] | ||
/* Enable (or disable) anon users, defaults to true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. Still not sure about the default value though...@flovilmart do you want to weigh in on this?