Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Year cosmetics :) #4475

Merged
merged 5 commits into from
Jan 1, 2018
Merged

New Year cosmetics :) #4475

merged 5 commits into from
Jan 1, 2018

Conversation

vitaly-t
Copy link
Contributor

@vitaly-t vitaly-t commented Dec 31, 2017 •
edited
Loading

Making nicer, more consistent promise pattern use + if->else blocks.

@vitaly-t
cosmetics
72de2e2 
* making nicer promise pattern + if->else blocks
* removing return if unwanted data from an `UPDATE`
@vitaly-t
Update PostgresStorageAdapter.js
1f13015
@vitaly-t vitaly-t changed the title cosmetics New Year cosmetics :) Dec 31, 2017
@vitaly-t
Update PostgresStorageAdapter.js
4f5a1aa
@vitaly-t
Update PostgresStorageAdapter.js
c20e8e9 
Restoring the `UPDATE` result, as apparently it is in fact used. Ouch! 😄
@codecov
Copy link

codecov bot commented Jan 1, 2018 •
edited
Loading

Codecov Report

Merging #4475 into master will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4475      +/-   ##
==========================================
- Coverage   92.78%   92.77%   -0.02%     
==========================================
  Files         118      118              
  Lines        8372     8373       +1     
==========================================
  Hits         7768     7768              
- Misses        604      605       +1
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.97% <85.71%> (ø) ⬆️
src/Adapters/Auth/meetup.js 84.21% <0%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1063137...5628d34. Read the comment docs.

montymxb
montymxb approved these changes Jan 1, 2018
View reviewed changes
Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Housekeeping is always nice :octocat:

@vitaly-t vitaly-t merged commit fc6a2fd into master Jan 1, 2018
@vitaly-t vitaly-t deleted the vitaly-t-patch-1 branch January 1, 2018 20:33
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@vitaly-t
New Year cosmetics :) (parse-community#4475)
3b58977 
* cosmetics

* making nicer promise pattern + if->else blocks
* removing return if unwanted data from an `UPDATE`

* Update PostgresStorageAdapter.js

* Update PostgresStorageAdapter.js

* Update PostgresStorageAdapter.js

Restoring the `UPDATE` result, as apparently it is in fact used. Ouch! 😄

* Update PostgresStorageAdapter.js
@snyk-bot snyk-bot mentioned this pull request Sep 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montymxb montymxb montymxb approved these changes

Assignees

@dplewis dplewis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitaly-t @montymxb @dplewis