Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exception when validating requests #4492

Closed
wants to merge 1 commit into from
Closed

Handle exception when validating requests #4492

wants to merge 1 commit into from

Conversation

bytedreamer
Copy link

If an empty request {} is sent, the server will crash.

If an empty request {} is sent, the server will crash.
Copy link
Contributor

@flovilmart flovilmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won’t work as you probably copied some compiled code from babel. Please double check your implementation and ideally, add a test.

@bytedreamer
Copy link
Author

Thanks, I'll spend some extra time implementing the fix properly. I wasn't sure if there were active reviewers of pull requests.

@stale
Copy link

stale bot commented Sep 18, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants