Updates definition build script for babel 7.0 #5024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5024 +/- ##
==========================================
- Coverage 94.24% 94.17% -0.07%
==========================================
Files 121 122 +1
Lines 8820 9080 +260
==========================================
+ Hits 8312 8551 +239
- Misses 508 529 +21
Continue to review full report at Codecov.
|
acinader
approved these changes
Sep 4, 2018
| @@ -107,8 +107,7 @@ | |||
| "lint-staged": { | |||
| "{src,spec}/**/*.js": [ | |||
| "prettier --write", | |||
| "flow", | |||
There was a problem hiding this comment.
if you're removing this, should @flow's come out too?
There was a problem hiding this comment.
Yeah, flow doesn’t take an argument, i’ll Find a way to add it back
flovilmart
added a commit
that referenced
this pull request
Sep 13, 2018
This reverts commit 617e840.
flovilmart
added a commit
that referenced
this pull request
Sep 13, 2018
This reverts commit 617e840.
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* Updates definition build script for babel 7.0 * run eslint on staged files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
@babel/coreto 7.0 has introduced a malfunction into the buildConfigDefinitions script that this PR addresses.