Decode Date JSON value at LiveQuery #5540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! I’ll see if this also works for LDS in the JS SDK. The test are passing but there is a flaky test. |
mrmarcsmith
approved these changes
Apr 27, 2019
dplewis
reviewed
Apr 30, 2019
dplewis
approved these changes
Apr 30, 2019
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date value stored in object is represented in JSON format like this:
{"__type": "Date", "iso": "2006-04-22T00:13:00.520Z"}It should be transformed to Date object before comparing, or it will always be failed.
That means all Date constraints at LiveQuery are actually failed.
P.S.
iOS / Mac client library should be modified as well, please check parse-community/ParseLiveQuery-iOS-OSX#186