-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Avoid setting a relation as required or with a defaultValue #5922
feat: Avoid setting a relation as required or with a defaultValue #5922
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5922 +/- ##
==========================================
- Coverage 93.68% 93.66% -0.03%
==========================================
Files 156 156
Lines 10850 10855 +5
==========================================
+ Hits 10165 10167 +2
- Misses 685 688 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also add a test for the case in which we are updating a schema with a new relation field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…rse-community#5922) * feat: Avoid setting a relation as required or with a defaultValue * chore: Test to update a class with a relation field with options * chore: Improve tests
No description provided.