Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Avoid setting a relation as required or with a defaultValue #5922

Merged

Conversation

alencarlucas
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #5922 into master will decrease coverage by 0.02%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5922      +/-   ##
==========================================
- Coverage   93.68%   93.66%   -0.03%     
==========================================
  Files         156      156              
  Lines       10850    10855       +5     
==========================================
+ Hits        10165    10167       +2     
- Misses        685      688       +3
Impacted Files Coverage Δ
src/Controllers/SchemaController.js 95.99% <80%> (-0.39%) ⬇️
src/RestWrite.js 93.72% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fddd9c2...e14dcce. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add a test for the case in which we are updating a schema with a new relation field?

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit b9839c1 into parse-community:master Aug 21, 2019
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
…rse-community#5922)

* feat: Avoid setting a relation as required or with a defaultValue

* chore: Test to update a class with a relation field with options

* chore: Improve tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants