-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support: serverCloseComplete option #5937
Conversation
Callback when server has fully shutdown. Please check that all cases are covered.
Codecov Report
@@ Coverage Diff @@
## master #5937 +/- ##
==========================================
- Coverage 93.67% 93.65% -0.03%
==========================================
Files 156 156
Lines 10838 10842 +4
==========================================
+ Hits 10153 10154 +1
- Misses 685 688 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Just a minor suggestion.
* Support: serverCloseComplete option Callback when server has fully shutdown. Please check that all cases are covered. * handle error on startup * fix tests * test workaround * remove serverCloseComplete chech on startup failure
Callback when server has fully shutdown. Adds documentation
Please check that all cases are covered.