Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support: serverCloseComplete option #5937

Merged
merged 5 commits into from
Aug 19, 2019
Merged

Support: serverCloseComplete option #5937

merged 5 commits into from
Aug 19, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Aug 18, 2019

Callback when server has fully shutdown. Adds documentation

Please check that all cases are covered.

Callback when server has fully shutdown.

Please check that all cases are covered.
@codecov
Copy link

codecov bot commented Aug 18, 2019

Codecov Report

Merging #5937 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5937      +/-   ##
==========================================
- Coverage   93.67%   93.65%   -0.03%     
==========================================
  Files         156      156              
  Lines       10838    10842       +4     
==========================================
+ Hits        10153    10154       +1     
- Misses        685      688       +3
Impacted Files Coverage Δ
src/Options/index.js 100% <ø> (ø) ⬆️
src/Options/Definitions.js 100% <ø> (ø) ⬆️
src/ParseServer.js 97.53% <100%> (+0.06%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.6% <0%> (-0.09%) ⬇️
src/RestWrite.js 93.72% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 750024f...2264465. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Just a minor suggestion.

src/ParseServer.js Show resolved Hide resolved
@dplewis dplewis requested a review from davimacedo August 19, 2019 04:29
@dplewis dplewis merged commit 1064f0c into master Aug 19, 2019
@dplewis dplewis deleted the server-close-complete branch August 19, 2019 05:25
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Support: serverCloseComplete option

Callback when server has fully shutdown.

Please check that all cases are covered.

* handle error on startup

* fix tests

* test workaround

* remove serverCloseComplete chech on startup failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants