Bootstreap script: use #!/bin/bash instead of #!/bin/sh #6062

brodo · 2019-09-18T13:16:00Z

The script uses double square brackets, which are a non-standard extension to []. The shebang line should reflect that. Some shells (e.g. dash, the default shell under Debian) do not support double square brackets. This leads to the script not working under Debian.

The script uses double square brackets, which are a non-standard extension to `[]`. Some shells (e.g. dash, the default shell under Debian) do not support double square brackets. The shebang line should reflect that.

codecov · 2019-09-19T05:36:51Z

Codecov Report

Merging #6062 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6062      +/-   ##
==========================================
- Coverage   93.74%   93.73%   -0.01%     
==========================================
  Files         164      164              
  Lines       11151    11151              
==========================================
- Hits        10453    10452       -1     
- Misses        698      699       +1

Impacted Files	Coverage Δ
src/RestWrite.js	`93.56% <0%> (-0.17%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7225c8e...eed3f2f. Read the comment docs.

davimacedo

Thanks for tackling this. LGTM!

The script uses double square brackets, which are a non-standard extension to `[]`. Some shells (e.g. dash, the default shell under Debian) do not support double square brackets. The shebang line should reflect that.

Use #!/bin/bash instead of #!/bin/sh

eed3f2f

The script uses double square brackets, which are a non-standard extension to `[]`. Some shells (e.g. dash, the default shell under Debian) do not support double square brackets. The shebang line should reflect that.

davimacedo approved these changes Sep 19, 2019

View reviewed changes

davimacedo merged commit 431cb94 into parse-community:master Sep 19, 2019

parseplatformorg mentioned this pull request May 6, 2024

refactor: Upgrade @graphql-tools/utils from 8.12.0 to 10.1.3 #9119

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bootstreap script: use #!/bin/bash instead of #!/bin/sh #6062

Bootstreap script: use #!/bin/bash instead of #!/bin/sh #6062

brodo commented Sep 18, 2019 •

edited

Loading

codecov bot commented Sep 19, 2019 •

edited

Loading

davimacedo left a comment

Bootstreap script: use #!/bin/bash instead of #!/bin/sh #6062

Bootstreap script: use #!/bin/bash instead of #!/bin/sh #6062

Conversation

brodo commented Sep 18, 2019 • edited Loading

codecov bot commented Sep 19, 2019 • edited Loading

Codecov Report

davimacedo left a comment

Choose a reason for hiding this comment

brodo commented Sep 18, 2019 •

edited

Loading

codecov bot commented Sep 19, 2019 •

edited

Loading