Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: Handle required fields from Parse Schema #6271

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

Moumouls
Copy link
Member

@Moumouls Moumouls commented Dec 9, 2019

A little improvement for better front DX

@Moumouls Moumouls requested a review from davimacedo December 9, 2019 14:30
@Moumouls
Copy link
Member Author

Moumouls commented Dec 9, 2019

Seems we have a Postgres extension fail

@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #6271 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6271      +/-   ##
=========================================
- Coverage   93.85%   93.8%   -0.05%     
=========================================
  Files         169     169              
  Lines       11564   11564              
=========================================
- Hits        10853   10848       -5     
- Misses        711     716       +5
Impacted Files Coverage Δ
src/GraphQL/loaders/parseClassTypes.js 94.23% <ø> (ø) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.74% <0%> (-0.71%) ⬇️
src/RestWrite.js 93.58% <0%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad7e7a...afd9a23. Read the comment docs.

@Moumouls
Copy link
Member Author

Moumouls commented Dec 9, 2019

@dplewis
Copy link
Member

dplewis commented Dec 10, 2019

@Moumouls I'll fix it in another PR. You should be good for now.

@davimacedo davimacedo merged commit e0e06ef into parse-community:master Dec 12, 2019
@Moumouls
Copy link
Member Author

I'll push again on this branch, i missed to add required field on output fields...

@davimacedo
Copy link
Member

Maybe it would be better to send a new pr with the output.

UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants