-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix read preference for aggregate #6585
Fix read preference for aggregate #6585
Conversation
The fix in parse-community/Parse-SDK-JS#1143 seems to work looking at the mongodb logs. But I am stuck verifying the read preference in the test case. I don't know what to
@dplewis Can you help me out on this? |
@davimacedo Is the expert on readPreferences and wrote most of the tests. |
Alright, got the test case fixed for aggregate. |
All parse server tests pass locally with the parse SDK merged with fix parse-community/Parse-SDK-JS#1143. So before merging this PR the new parse SDK has to be released. |
…ce-for-aggregate-on-query-option
@acinader ready for review |
Codecov Report
@@ Coverage Diff @@
## master #6585 +/- ##
=======================================
Coverage 93.92% 93.92%
=======================================
Files 169 169
Lines 11991 11994 +3
=======================================
+ Hits 11262 11265 +3
Misses 729 729
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks! |
added failing test cases