Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add context to Parse.Object.save #6626

Merged
merged 4 commits into from
Apr 28, 2020
Merged

add context to Parse.Object.save #6626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ae9c15
added failing test
mtrezza Apr 18, 2020
dad815d
added parsing of context in REST save request
mtrezza Apr 18, 2020
60b2f1c
undo lint changes
mtrezza Apr 18, 2020
51010fc
Merge remote-tracking branch 'upstream/master' into add-context-to-save
mtrezza Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions spec/CloudCode.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2911,4 +2911,17 @@ describe('afterLogin hook', () => {
await Parse.User.logIn('testuser', 'p@ssword');
done();
});

it('should have access to context as save argument', async () => {
// Declare triggers
Parse.Cloud.beforeSave('TestObject', (req) => {
expect(req.context.a).toEqual('a');
});
Parse.Cloud.afterSave('TestObject', (req) => {
expect(req.context.a).toEqual('a');
});
// Save object
const obj = new TestObject();
await obj.save(null, { context: { a: 'a' } });
});
});
5 changes: 5 additions & 0 deletions src/RestWrite.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ function RestWrite(
}

if (!query) {
// Parse context
if (data._context && data._context instanceof Object) {
this.context = data._context;
delete data._context;
}
if (this.config.allowCustomObjectId) {
if (
Object.prototype.hasOwnProperty.call(data, 'objectId') &&
Expand Down