Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle shutdown for RedisCacheAdapter #6658

Merged
merged 2 commits into from
Apr 30, 2020

Conversation

promisenxu
Copy link
Contributor

Call handleShutdown of RedisCacheAdapter in the handleShutdown part of Parse Server

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #6658 into master will increase coverage by 10.14%.
The diff coverage is 80.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6658       +/-   ##
===========================================
+ Coverage   83.73%   93.88%   +10.14%     
===========================================
  Files         169      169               
  Lines       11997    12007       +10     
===========================================
+ Hits        10046    11273     +1227     
+ Misses       1951      734     -1217     
Impacted Files Coverage Δ
src/ParseServer.js 89.47% <62.50%> (-1.60%) ⬇️
src/Adapters/Cache/RedisCacheAdapter/index.js 94.64% <88.88%> (-3.32%) ⬇️
src/RestWrite.js 93.67% <0.00%> (ø)
src/Routers/UsersRouter.js 94.33% <0.00%> (+0.62%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.52% <0.00%> (+0.66%) ⬆️
src/Controllers/UserController.js 94.39% <0.00%> (+0.93%) ⬆️
src/Controllers/FilesController.js 93.61% <0.00%> (+2.12%) ⬆️
src/Adapters/Storage/Postgres/PostgresClient.js 86.66% <0.00%> (+80.00%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.33% <0.00%> (+93.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800b039...760c065. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM!

@davimacedo davimacedo merged commit 67bf868 into parse-community:master Apr 30, 2020
@promisenxu
Copy link
Contributor Author

Thanks! My first-ever pull request on GitHub!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants