Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL: Optimize queries, fixes some null returns (on object), fix stitched GraphQLUpload #6709

Merged
merged 6 commits into from
Oct 1, 2020
Merged

GraphQL: Optimize queries, fixes some null returns (on object), fix stitched GraphQLUpload #6709

merged 6 commits into from
Oct 1, 2020

Conversation

Moumouls
Copy link
Member

No description provided.

@Moumouls Moumouls requested a review from davimacedo May 26, 2020 19:07
@Moumouls Moumouls self-assigned this May 26, 2020
@Moumouls Moumouls changed the title Optimize query, fixes some null returns, fix stitched GraphQLUpload GraphQL: Optimize queries, fixes some null returns (on object), fix stitched GraphQLUpload May 26, 2020
@codecov
Copy link

codecov bot commented May 26, 2020 •
edited
Loading

Codecov Report

Merging #6709 into master will decrease coverage by 0.01%.
The diff coverage is 96.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6709      +/-   ##
==========================================
- Coverage   93.79%   93.77%   -0.02%     
==========================================
  Files         169      169              
  Lines       12220    12216       -4     
==========================================
- Hits        11462    11456       -6     
- Misses        758      760       +2
Impacted Files Coverage Δ
src/Controllers/SchemaController.js 96.92% <ø> (ø)
src/Config.js 89.92% <50.00%> (-0.66%) ⬇️
src/Routers/InstallationsRouter.js 84.21% <50.00%> (ø)
src/Adapters/Files/GridFSBucketAdapter.js 77.64% <75.00%> (ø)
src/Adapters/Auth/google.js 92.95% <90.90%> (+0.10%) ⬆️
src/middlewares.js 97.18% <91.66%> (-0.44%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.02% <100.00%> (ø)
src/GraphQL/helpers/objectsMutations.js 83.33% <100.00%> (ø)
src/GraphQL/helpers/objectsQueries.js 90.83% <100.00%> (ø)
src/GraphQL/loaders/defaultGraphQLTypes.js 97.06% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 929c4e1...2dcdfb3. Read the comment docs.

@Moumouls Moumouls force-pushed the fix-gql-null-object-opti-issues branch from acd07aa to 8c50b89 Compare May 27, 2020 09:23
@Moumouls
Copy link
Member Author

Moumouls commented Oct 1, 2020

@mtrezza @davimacedo can we merge this ?

@mtrezza
Copy link
Member

mtrezza commented Oct 1, 2020

I'm OOO today, so I won't have a chance to review immediately. The enhancement makes sense in principle though.

@Moumouls Moumouls linked an issue Oct 1, 2020 that may be closed by this pull request
GraphQL: Query on Object field type resolve to null #6631
Closed
davimacedo
davimacedo approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I missed this one. Could you please just resolve the conflict?

@davimacedo
Copy link
Member

Actually I've resolved myself. Let's just wait for the CI and we can merge.

@davimacedo davimacedo merged commit 6204826 into parse-community:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo davimacedo approved these changes

@mtrezza mtrezza Awaiting requested review from mtrezza

@omairvaiyani omairvaiyani Awaiting requested review from omairvaiyani

Assignees

@Moumouls Moumouls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GraphQL: Query on Object field type resolve to null
3 participants
@Moumouls @mtrezza @davimacedo