Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Prettier JS #2 #6796

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Run Prettier JS #2 #6796

merged 1 commit into from
Jul 13, 2020

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 13, 2020

Remove arrow parentheses for single argument arrow functions.

@dplewis dplewis requested review from davimacedo and mtrezza July 13, 2020 21:55
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Let's just wait for the CI.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, the space-after-function seems to be a minor question, looking at it by volume.

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #6796 into master will increase coverage by 0.00%.
The diff coverage is 98.89%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6796   +/-   ##
=======================================
  Coverage   93.90%   93.91%           
=======================================
  Files         169      169           
  Lines       12054    12054           
=======================================
+ Hits        11319    11320    +1     
+ Misses        735      734    -1     
Impacted Files Coverage Δ
src/Controllers/AnalyticsController.js 83.33% <ø> (ø)
src/Controllers/PushController.js 97.84% <ø> (ø)
src/LiveQuery/SessionTokenCache.js 86.95% <ø> (ø)
src/Routers/FeaturesRouter.js 100.00% <ø> (ø)
src/Routers/GraphQLRouter.js 46.66% <ø> (ø)
src/Routers/IAPValidationRouter.js 85.00% <ø> (ø)
src/Routers/PurgeRouter.js 83.33% <ø> (ø)
src/Controllers/LoggerController.js 91.57% <50.00%> (ø)
src/Routers/FilesRouter.js 86.06% <75.00%> (ø)
src/Controllers/DatabaseController.js 95.19% <100.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a6354...139f43e. Read the comment docs.

@davimacedo davimacedo merged commit 142eaa7 into master Jul 13, 2020
@dplewis dplewis deleted the prettier-2 branch July 13, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants