-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mutating beforeSubscribe Query #6868
Conversation
@dblythy Can you rebase from master branch? This will fix the failing tests. |
726fd46
to
31bbbf2
Compare
@dplewis thank you for fixing the other tests! Still one test failing for me:
Is this related to my PR? |
Most likely not. You can try to close and reopen this PR and see whether the test passes. We are having an issue with intermittently failing test cases which may be the reason why this test fails. |
I believe this PR is failing for Postgres tests. |
Any ideas why @davimacedo? The travis-ci logs aren't providing anything useful. |
Nevermind. It was actually intermittently failing. |
Codecov Report
@@ Coverage Diff @@
## master #6868 +/- ##
==========================================
+ Coverage 93.78% 93.81% +0.02%
==========================================
Files 168 168
Lines 12185 12189 +4
==========================================
+ Hits 11428 11435 +7
+ Misses 757 754 -3
Continue to review full report at Codecov.
|
I restarted the job. Looks good. |
Thank you gents!! |
Fixes #6866, and now allows returning a new query.
Also adds additional test cases for
beforeSubscribe
. Failing tests are not related to this PR.@mtrezza, any other tests required to make sure it's 100%?