Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PostgresStorageAdapter.js #6981

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Update PostgresStorageAdapter.js #6981

merged 2 commits into from
Oct 30, 2020

Conversation

vitaly-t
Copy link
Contributor

@vitaly-t vitaly-t commented Oct 30, 2020

Start moving toward better, ES7 syntax.

In this case, the batch is not needed, and it is better to use ES7 syntax, to avoid creating other requests, if a previous one fails.

Start moving toward better, ES7 syntax.
@ghost
Copy link

ghost commented Oct 30, 2020

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #6981 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6981      +/-   ##
==========================================
- Coverage   93.81%   93.81%   -0.01%     
==========================================
  Files         169      169              
  Lines       12402    12409       +7     
==========================================
+ Hits        11635    11641       +6     
- Misses        767      768       +1     
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.89% <100.00%> (+0.02%) ⬆️
src/Routers/PushRouter.js 93.10% <0.00%> (-3.45%) ⬇️
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) ⬇️
src/RestWrite.js 93.65% <0.00%> (-0.33%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.58% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f261cc...9b3aa28. Read the comment docs.

Fixing spaces 🤦‍♂️
@vitaly-t
Copy link
Contributor Author

After an unsuccessful build... I don't know why it is failing, but it doesn't seem related to these changes.

@dplewis
Copy link
Member

dplewis commented Oct 30, 2020

There are some false positive tests. You can restart Travis jobs

@vitaly-t
Copy link
Contributor Author

You can restart Travis jobs

My account doesn't seem to have the permission to restart Travis jobs for this project.

@davimacedo davimacedo merged commit 82cd275 into parse-community:master Oct 30, 2020
@vitaly-t vitaly-t deleted the patch-2 branch October 30, 2020 23:31
dblythy pushed a commit to dblythy/parse-server that referenced this pull request Dec 14, 2020
* Update PostgresStorageAdapter.js

Start moving toward better, ES7 syntax.

* Update PostgresStorageAdapter.js

Fixing spaces 🤦‍♂️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants