Add KeyPromiseQueue to Push and Job StatusHandlers

[dplewis]

New Pull Request Checklist

• I am not disclosing a vulnerability.
• I am creating this PR in reference to an issue.

Issue Description

The current promise chain can lead to unwanted behavior like older update overriding the latest and timeouts. This could also be the cause for a lot of flaky tests.

Approach

This reused the KeyPromiseQueue used in the RedisCacheAdapter. The operations for push and jobs are queue by the objectId of the status objects. Not only will it reduce bottlenecks for request but it is designed that way to allow maximum data consistency and prevent operations from overlapping.

TODOs before merging

• Add test cases
• Add entry to changelog
• Add changes to documentation (guides, repository pages, in-code descriptions)
• Add security check
• Add new Parse Error codes to Parse JS SDK
• ...

[codecov]

Codecov Report

Merging #7267 (e7d5e0d) into master (f7d2e09) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7267      +/-   ##
==========================================
- Coverage   94.01%   93.96%   -0.05%     
==========================================
  Files         179      179              
  Lines       13144    13138       -6     
==========================================
- Hits        12357    12345      -12     
- Misses        787      793       +6     

Impacted Files	Coverage Δ
src/KeyPromiseQueue.js	95.45% <ø> (ø)
src/Adapters/Cache/RedisCacheAdapter.js	94.73% <100.00%> (ø)
src/StatusHandler.js	98.49% <100.00%> (-0.07%)	⬇️
src/batch.js	91.37% <0.00%> (-1.73%)	⬇️
src/Adapters/Files/GridFSBucketAdapter.js	79.50% <0.00%> (-0.82%)	⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js	92.25% <0.00%> (-0.67%)	⬇️
src/RestWrite.js	93.84% <0.00%> (-0.17%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7d2e09...4524819. Read the comment docs.

[davimacedo]

@dplewis the tests are not passing. I'm not sure if it is because of this PR or the others we've already commited.

[dplewis]

I think going forward we should ignore flaky test and test with network timeouts (transactions PG only and Parse.Push fixed here hopefully) until they are fixed. Otherwise reviews will take longer and we will be endlessly re running the CI in some cases.

@mtrezza What do you think?

[mtrezza]

we should ignore flaky test and test with network timeouts

Yes, that's an option. I was actually hoping that the annoyance of re-running tests incentivizes to fix the tests. My only concern would be that "hiding" the flakiness would lead to tests not being looked into and we end up piling them up, or even worse, hiding bugs. Didn't we fix most of the tests already?

[dplewis]

Didn't we fix most of the tests already?

Yes we have. I don't know how many are left or which ones have been fixed. I assume there are about < 6 flaky tests left.

I was actually hoping that the annoyance of re-running tests incentivizes to fix the tests.

Annoyance is why I fixed the tests lol.

[mtrezza]

Annoyance is why I fixed the tests lol.

Hah! There you go, why would we want to change a working strategy 😉

[dplewis]

We will still keep track of the flaky tests since they will be easier to find now. The transaction network timeouts shouldn't be a show stopper

@mtrezza What about this PR?

[mtrezza]

If that a FIFO queue? I think that's a good approach, doesn't seem related to the transactions test fails? I restarted.

[dplewis]

If that a FIFO queue? I think that's a good approach, doesn't seem related to the transactions test fails? I restarted.

Thats right, also seems like the CI is stuck.
https://www.githubstatus.com/incidents/s654n76c1bwr

[mtrezza]

Ah good, I would still wait to merge until actions work again, just to be sure.

[parseplatformorg]

🎉 This change has been released in version 5.0.0-beta.1

[parseplatformorg]

🎉 This change has been released in version 5.0.0