-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for $eq in LiveQuery #7607
Closed
sadakchap
wants to merge
15
commits into
parse-community:alpha
from
sadakchap:feat/sendLiveQueryEvent
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
55b68ea
feat(LiveQuery): Support $eq
sadakchap 2b52e34
updated changelog.md
sadakchap 3d06b2d
Merge branch 'master' into feat/sendLiveQueryEvent
sadakchap d0554df
Merge branch 'master' into feat/sendLiveQueryEvent
mtrezza 0287282
Update CHANGELOG.md
mtrezza f8b4f7b
added test case for new format query
sadakchap adef3de
Merge branch 'feat/sendLiveQueryEvent' of github.com:sadakchap/parse-…
sadakchap 4beea42
Merge branch 'alpha' of github.com:parse-community/parse-server into …
sadakchap 24e5964
Merge branch 'alpha' into feat/sendLiveQueryEvent
mtrezza d35ce85
added more testcase for new query format
sadakchap 825db53
Merge branch 'alpha' into feat/sendLiveQueryEvent
mtrezza e864fd2
added testcase for array type
sadakchap 8d5021f
using objectId instead of id in testcases
sadakchap 70e6de8
Merge branch 'feat/sendLiveQueryEvent' of github.com:sadakchap/parse-…
sadakchap dd3ce1a
Merge branch 'alpha' into feat/sendLiveQueryEvent
mtrezza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this related to "add support for $eq in LiveQuery"? This is not a LiveQuery test. Is this a test for parse-community/Parse-SDK-JS#1373 which is a separate issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since in parse-community/Parse-SDK-JS#1373, we are changing the format of
query
. There are certain LiveQuery tests(parse-sdk-js) which are failing because parse-server doesn't support new query format for LiveQuery.So, we added support for new
query
format in LiveQuery in parse-server.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I follow; is parse-community/Parse-SDK-JS#1373 a requirement for this PR? I don't think so, otherwise the tests in this PR wouldn't already pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually its the other, please follow this parse-community/Parse-SDK-JS#1373 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I understand that the tests in parse-community/Parse-SDK-JS#1373 will only pass when this PR (#7607) has been merged. But they relate to 2 different features:
So why is parse-community/Parse-SDK-JS#1373 mentioned in this test case if this PR (#7607) has no dependency on parse-community/Parse-SDK-JS#1373, only the other way around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtrezza sorry, I could not understand you properly, could you please elaborate a bit more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, it seems these are 2 different features:
Even if parse-community/Parse-SDK-JS#1373 never gets merged, we would still want to merge #7607 as a feature, right? So I don't understand why the tests in #7607 mention parse-community/Parse-SDK-JS#1373: