-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove unnecessary error checking in PostgresAdapter #7761
Conversation
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## alpha #7761 +/- ##
==========================================
+ Coverage 93.96% 93.99% +0.02%
==========================================
Files 183 183
Lines 13640 13635 -5
==========================================
- Hits 12817 12816 -1
+ Misses 823 819 -4
Continue to review full report at Codecov.
|
@mtrezza this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
🎉 This change has been released in version 5.0.0-alpha.16 |
🎉 This change has been released in version 5.0.0-beta.10 |
🎉 This change has been released in version 5.1.0 |
New Pull Request Checklist
Issue Description
There are unnecessary error checks in
PostgresStorageAdapter.js
that were left over from addingIF NOT EXISTS
in #6741 and #6506Related issue: #6741 and #6506
Approach
Remove error checks and code that isn't used anymore.
TODOs before merging