Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: internal indices for classes _Idempotency and _Role are not protected in defined schema #8121

Merged
merged 3 commits into from
Aug 5, 2022
Merged

fix: internal indices for classes _Idempotency and _Role are not protected in defined schema #8121

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de6599c
fix: defined schema protected indexes
Moumouls Aug 3, 2022
a601269
Update spec/DefinedSchemas.spec.js
mtrezza Aug 3, 2022
9ac5687
Update spec/DefinedSchemas.spec.js
mtrezza Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions spec/DefinedSchemas.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,40 @@ describe('DefinedSchemas', () => {
expect(testSchema.indexes).toBeUndefined();
expect(userSchema.indexes).toEqual(expectedIndexes);
});

it('should detect protected indexes for _User class', () => {
const definedSchema = new DefinedSchemas({}, {});
const protectedUserIndexes = ['_id_', 'case_insensitive_email', 'username_1', 'email_1'];
protectedUserIndexes.forEach(field => {
expect(definedSchema.isProtectedIndex('_User', field)).toEqual(true);
});
expect(definedSchema.isProtectedIndex('_User', 'test')).toEqual(false);
});
it('should detect protected indexes for _Role class', () => {
mtrezza marked this conversation as resolved.
Show resolved Hide resolved
const definedSchema = new DefinedSchemas({}, {});
expect(definedSchema.isProtectedIndex('_Role', 'name_1')).toEqual(true);
expect(definedSchema.isProtectedIndex('_Role', 'test')).toEqual(false);
});
it('should detect protected indexes for _Idempotency class', () => {
mtrezza marked this conversation as resolved.
Show resolved Hide resolved
const definedSchema = new DefinedSchemas({}, {});
expect(definedSchema.isProtectedIndex('_Idempotency', 'reqId_1')).toEqual(true);
expect(definedSchema.isProtectedIndex('_Idempotency', 'test')).toEqual(false);
});

it('should not detect protected indexes on user defined class', () => {
const definedSchema = new DefinedSchemas({}, {});
const protectedIndexes = [
'case_insensitive_email',
'username_1',
'email_1',
'reqId_1',
'name_1',
];
protectedIndexes.forEach(field => {
expect(definedSchema.isProtectedIndex('ExampleClass', field)).toEqual(false);
});
expect(definedSchema.isProtectedIndex('ExampleClass', '_id_')).toEqual(true);
});
});

describe('ClassLevelPermissions', () => {
Expand Down
26 changes: 17 additions & 9 deletions src/SchemaMigrations/DefinedSchemas.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,15 +399,23 @@ export class DefinedSchemas {
}

isProtectedIndex(className: string, indexName: string) {
let indexes = ['_id_'];
if (className === '_User') {
indexes = [
...indexes,
'case_insensitive_username',
'case_insensitive_email',
'username_1',
'email_1',
];
const indexes = ['_id_'];
switch (className) {
case '_User':
indexes.push(
'case_insensitive_username',
'case_insensitive_email',
'username_1',
'email_1'
);
break;
case '_Role':
indexes.push('name_1');
break;

case '_Idempotency':
indexes.push('reqId_1');
break;
}

return indexes.indexOf(indexName) !== -1;
Expand Down