Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade mongodb to 4.14.0 #8438

Closed

Conversation

tomkretzschmar
Copy link

@tomkretzschmar tomkretzschmar commented Feb 23, 2023

Pull Request

Issue

Closes: n/a

  • Parse-server loses mongoDB connection in a k8s setup when mongoDB primaries are restarted.
  • This is fixed in node-mongodb-native v4.11.0

Approach

  • Upgrade mongodb driver to v4.14.0

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title refactor: upgrade mongodb to 4.14 refactor: Upgrade mongodb to 4.14 Feb 23, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 23, 2023

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@mtrezza
Copy link
Member

mtrezza commented Feb 23, 2023

There are quite a lot of changes in package lock. Which npm commands did you run? Seems like it contains more than only the mongodb upgrade?

@tomkretzschmar
Copy link
Author

I ran npm install mongodb@4.14 as npm update mongodb didn't result in any chances due to no version range being specified in the package.json

@mtrezza
Copy link
Member

mtrezza commented Feb 24, 2023

This looks all strange. Even the package version is not a semver syntax. Could you please revert everything (or start a new PR) and then just run npm i -E mongodb@4.14.0.

Btw the newest version is 15.x, in case you want to upgrade to that. But that would likely require you to also make some code changes.

@tomkretzschmar
Copy link
Author

Did so, same changeset.

Updated the description, 4.14 is enough for us currently.

@mtrezza
Copy link
Member

mtrezza commented Feb 27, 2023

Hard to believe that version 4.14 is the result of this. It's not semver conform.

@tomkretzschmar
Copy link
Author

output of npm i -E mongodb@4.14.0

 ~/repos/parse-server  upgrade-mongodb  npm i -E mongodb@4.14.0                    [10:57:25]

added 74 packages, removed 1 package, changed 1 package, and audited 1877 packages in 8s

124 packages are looking for funding
  run `npm fund` for details

33 vulnerabilities (1 low, 9 moderate, 18 high, 5 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

reset, updated again and force pushed the branch.

@mtrezza
Copy link
Member

mtrezza commented Feb 27, 2023

Looks better, the version is now correct: "mongodb": "4.14.0"

@mtrezza mtrezza changed the title refactor: Upgrade mongodb to 4.14 refactor: Upgrade mongodb to 4.14.0 Feb 27, 2023
@mtrezza
Copy link
Member

mtrezza commented Feb 27, 2023

So it seems that, even though the upgrade is likely not a breaking change, the tests need to be adapted for the upgrade.

@mtrezza
Copy link
Member

mtrezza commented May 21, 2023

Closing due to inactivity.

@mtrezza mtrezza closed this May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants