-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Upgrade mongodb to 4.14.0 #8438
refactor: Upgrade mongodb to 4.14.0 #8438
Conversation
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request!
|
There are quite a lot of changes in package lock. Which npm commands did you run? Seems like it contains more than only the mongodb upgrade? |
9cca0b0
to
013f3fe
Compare
I ran |
This looks all strange. Even the package version is not a semver syntax. Could you please revert everything (or start a new PR) and then just run Btw the newest version is 15.x, in case you want to upgrade to that. But that would likely require you to also make some code changes. |
Did so, same changeset. Updated the description, 4.14 is enough for us currently. |
Hard to believe that version |
013f3fe
to
c2909d2
Compare
output of
reset, updated again and force pushed the branch. |
Looks better, the version is now correct: |
So it seems that, even though the upgrade is likely not a breaking change, the tests need to be adapted for the upgrade. |
Closing due to inactivity. |
Pull Request
Issue
Closes: n/a
Approach