Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deny requests for ip restricted master keys #8831

Closed
wants to merge 3 commits into from

Conversation

suathh
Copy link

@suathh suathh commented Dec 11, 2023

Pull Request

Issue

Closes: #8829

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

Copy link

parse-github-assistant bot commented Dec 11, 2023

Thanks for opening this pull request!

@mtrezza
Copy link
Member

mtrezza commented Dec 13, 2023

@suathh Tests are failing, could you please take a look?

@mtrezza mtrezza changed the title deny requests for ip restricted master keys #8829 fix: deny requests for ip restricted master keys Dec 25, 2023
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: deny requests for ip restricted master keys fix: Deny requests for ip restricted master keys Dec 25, 2023
@suathh
Copy link
Author

suathh commented Jan 2, 2024

@mtrezza Most of the fails are because of the update we are doing.

The test fails with these lines

  • Error: Access denied: IP address '127.0.0.1' is not authorized to use the master key.

Denial of Master Key 2
Denial of Master Key

But one test has a different problem which is the Node v14 test, it is timeout for live query

Timeout

@mtrezza
Copy link
Member

mtrezza commented Jan 2, 2024

What do you suggest as solution?

@suathh
Copy link
Author

suathh commented Jan 2, 2024

At this point, I need to check what those failing tests stand for and what they are doing. It would be better to take advice or help from the test creators or someone who knows what they stand for.

But as an oversight, what I see from error logs;

  1. We need to add local IP addresses to our Parse-Server config for our tests. In this case 127.0.0.1 but that won't work if the test env running on an IPv6 env.
  2. Update the tests according to our breaking change
  3. Remove the failing tests cause they are trying to test a breaking change but this will eventually lead to step 2

@EhsanParsania
Copy link
Member

I have fixed the test cases that were related to this current change, there are still more failed tests are exist but they are unrelated to this change, please give me Write access to this pull request so I can push my commit @suathh @mtrezza

@mtrezza
Copy link
Member

mtrezza commented Mar 23, 2024

Superseded by #8957

@mtrezza mtrezza closed this Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server logs master key error even if it has been not used
3 participants