-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Remove unnecessary setTimeout
and reconfigureServer
calls
#9183
Conversation
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9183 +/- ##
==========================================
- Coverage 94.16% 85.34% -8.82%
==========================================
Files 186 186
Lines 14729 14738 +9
==========================================
- Hits 13869 12578 -1291
- Misses 860 2160 +1300 ☔ View full report in Codecov by Sentry. |
🎉 This change has been released in version 7.1.0-alpha.16 |
🎉 This change has been released in version 7.2.0-beta.1 |
🎉 This change has been released in version 7.2.0 |
Pull Request
Issue
Since the LiveQuery server is enabled by default in the test suite some test call reconfigureServer redundently. There are a lot of setTimeout calls which stalls the test suite.
Approach
xit('can handle live query with fields)
liveQueryClient.close
returns a promise. no longer need to wait with setTimeoutTasks