Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove unnecessary setTimeout and reconfigureServer calls #9183

Merged
merged 7 commits into from
Jul 8, 2024

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 8, 2024

Pull Request

Issue

Since the LiveQuery server is enabled by default in the test suite some test call reconfigureServer redundently. There are a lot of setTimeout calls which stalls the test suite.

Approach

  • Save ~50 seconds
  • Enable xit('can handle live query with fields)
  • Replace setTimeout with deferred promises as needed
  • Refactor setTimeout
  • Improve verbose logging
  • Remove console warnings
  • Remove unnecessary server restarts
  • liveQueryClient.close returns a promise. no longer need to wait with setTimeout

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

Copy link

parse-github-assistant bot commented Jul 8, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.34%. Comparing base (e7199e8) to head (05cc7aa).
Report is 3 commits behind head on alpha.

❗ There is a different number of reports uploaded between BASE (e7199e8) and HEAD (05cc7aa). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (e7199e8) HEAD (05cc7aa)
14 7
Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #9183      +/-   ##
==========================================
- Coverage   94.16%   85.34%   -8.82%     
==========================================
  Files         186      186              
  Lines       14729    14738       +9     
==========================================
- Hits        13869    12578    -1291     
- Misses        860     2160    +1300     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested review from mtrezza and a team July 8, 2024 13:26
@mtrezza mtrezza merged commit a6e0a1d into parse-community:alpha Jul 8, 2024
2 checks passed
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-alpha.16

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jul 8, 2024
@dplewis dplewis deleted the ci-speedup branch July 9, 2024 00:12
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.2.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jul 9, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants