-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix invalid MongoDB version ranges for tests #9474
Merged
mtrezza
merged 10 commits into
parse-community:alpha
from
mtrezza:ci/fix-invalid-mongodb-version-ranges
Dec 9, 2024
Merged
ci: Fix invalid MongoDB version ranges for tests #9474
mtrezza
merged 10 commits into
parse-community:alpha
from
mtrezza:ci/fix-invalid-mongodb-version-ranges
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9474 +/- ##
==========================================
+ Coverage 93.50% 93.51% +0.01%
==========================================
Files 186 186
Lines 14810 14810
==========================================
+ Hits 13848 13850 +2
+ Misses 962 960 -2 ☔ View full report in Codecov by Sentry. |
🎉 This change has been released in version 7.4.0-alpha.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Some MongoDB version ranges for tests that are using
it_only_mongodb_version
do not use valid semver version ranges. Therefore these tests are skipped viaxit
for certain MongoDB versions even though they should run.Example:
Invalid disjoint range:
<5.1>=6
should be<5.1 || >=6
Invalid closed range:
>=5.1<6
should be>=5.1 <6
(missing space)Approach
it_only_mongodb_version
and similar methods more robust by failing test withError: Invalid version range
on invalid version range.fit_exclude_node_version
which is justfit_only_node_version
with the inverse version range.Tasks