Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple SendGrid email adapter #971

Closed
wants to merge 1 commit into from

Conversation

carmenlau
Copy link
Contributor

@codecov-io
Copy link

Current coverage is 90.64%

Merging #971 into master will decrease coverage by -0.78% as of 2aa08be

@@            master    #971   diff @@
======================================
  Files           73      73       
  Stmts         4384    4384       
  Branches       876     876       
  Methods          0       0       
======================================
- Hit           4008    3974    -34
  Partial         10      10       
- Missed         366     400    +34

Review entire Coverage Diff as of 2aa08be

Powered by Codecov. Updated on successful CI builds.

@gfosco
Copy link
Contributor

gfosco commented Mar 11, 2016

We'd prefer that new adapters (and even the ones we have now) be moved to separate NPM packages. parse-server-sendgrid-adapter could be a good name for this one. It would be easier to require('parse-server-sendgrid-adapter') than require('parse-server/lib/Adapters/Email/SimpleSendgridAdapter') and it would put the testing/maintenance burden on the adapter developer (rather than on the core parse-server community.)

See: https://docs.npmjs.com/getting-started/publishing-npm-packages

@facebook-github-bot
Copy link

@carmenlau updated the pull request.

@noder199
Copy link

@gfosco How are we supposed to find/setup these adapters?

@gfosco
Copy link
Contributor

gfosco commented Mar 14, 2016

Through NPM, and through our wiki.. I've also thought about building a search/discovery spot for parse-server modules.

@facebook-github-bot
Copy link

@carmenlau updated the pull request.

@carmenlau
Copy link
Contributor Author

I have put this to npm and I am going to close this PR.
https://www.npmjs.com/package/parse-server-sendgrid-adapter

Search/discovery spot for parse-server modules are good idea. Thanks all for your help.

@zeluspudding
Copy link

Does the adapter support SendGrid's email templates?

@gowridev
Copy link

when sendgrid-adapter module is added to parse server git master?

@zeluspudding
Copy link

@noder199, were you able to get this adapter setup? I did however I'm clearly not initializing two variables (one the app name the other the app's domain name) as shown below in a test password reset email . I've tracked the trigger for this email down to the defaultResetPasswordEmail function located in parse server's .\node_modules\parse-server\lib\Controllers\UserController.js script within the UserController class. My question is, and perhaps @carmenlau can answer this, how does one set the appName and domain to properly generate emails? Any help is appreciated

sendgridtest1

UPDATE:
Although I've configure missing fields described above (as layed out at #554 ) I still can't actually reset passwords. Any thoughts?

This was referenced Mar 21, 2016
@kalitas
Copy link

kalitas commented Oct 27, 2016

@zeluspudding did you manage to succeed with the password reset ? should i use the sendgrid adapter?

@zeluspudding
Copy link

zeluspudding commented Oct 28, 2016

I ended up waiting for the code to mature but then our project got cancelled so, unfortunately, no :( Wish I could help ya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants