Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If `from equals to, return 100% directly #12

Closed
wants to merge 1 commit into from
Closed

If `from equals to, return 100% directly #12

wants to merge 1 commit into from

Conversation

hotvulcan
Copy link

this fix when base === from === to, throw 'rates object does not contain either from or to currency!'

@hotvulcan
If `from equals to, return 100% directly
c3c0be4 
this fix when base === from === to, throw '`rates` object does not contain either `from` or `to` currency!'
xxczaki pushed a commit that referenced this pull request Jul 9, 2020
If from equals to, return 100% directly (#12)
afef56c
@xxczaki
Copy link
Member

xxczaki commented Jul 9, 2020

Thanks, added in afef56c 😄

@xxczaki xxczaki closed this Jul 9, 2020
@xxczaki xxczaki added the enhancement New feature or request label Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hotvulcan @xxczaki