Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache for more efficient refs #399

Closed
rdvdijk opened this issue Oct 24, 2023 · 0 comments · Fixed by #401
Closed

Add cache for more efficient refs #399

rdvdijk opened this issue Oct 24, 2023 · 0 comments · Fixed by #401
Milestone
10.0.0

Comments

@rdvdijk
Copy link
Contributor

rdvdijk commented Oct 24, 2023 •
edited
Loading

Using ref is sometimes extremely expensive when referencing values parsed very "early" in large ParseGraphs. This is a common pitfall in many tokens. We can improve this by creating a cache for all parsed values, which is used by evaluating a ref.

An example: the CFB format contains a 'sector size' in its header, which is used throughout the token. The lookup of this sector size becomes extremely slow in CFB with large sector chains.
mvanaken added a commit that referenced this issue Oct 24, 2023
@mvanaken
#399: Pass through the limit when using the ParseValueCache.
f9394ea 
The limit specifies the size of the result list. We can stop the filter
check once we hit the limit size.
mvanaken added a commit that referenced this issue Oct 24, 2023
@mvanaken
#399: Define a NO_CACHE constant that is used to indicate that cachin…
e2b259a 
…g is turned off.

This is needed e.g. for the scope value expression, where the ParseState
order is temporarily limited. The caching is then not usefull, since it
contains the caching for the whole graph. When `withOrder` is called, we
need to turn the caching off.
mvanaken added a commit that referenced this issue Oct 24, 2023
@mvanaken
#399: Add the cache info to the ToStringTest.
699ad9c
mvanaken added a commit that referenced this issue Oct 24, 2023
@mvanaken
#399: Fix the cache for ties.
ded9214 
The cache for ties should match the used parsegraph. We should not use
the cache of the original parsestate (returnParseState), but the cache
of the newest parsestate (within the environment).
mvanaken added a commit that referenced this issue Oct 24, 2023
@mvanaken
#399: Add ParseValueCache class to the AutoEqualityTest.
acf9d37
rdvdijk added a commit that referenced this issue Oct 26, 2023
@rdvdijk
#399 Fix Ref#withLimit so it creates the correct instance.
43df779
mvanaken added a commit that referenced this issue Nov 2, 2023
@mvanaken
#399: Add ParseValueCacheTest.
691f07e 
To specifically test cache behaviour, without the use of parsing and to
increase test coverage.
mvanaken added a commit that referenced this issue Nov 2, 2023
@mvanaken
#399: Cache is never null, so no need to check for it in toString.
5843a06
@mvanaken mvanaken linked a pull request Nov 2, 2023 that will close this issue
#399 Introducing ParseValueCache. #401
Merged
mvanaken added a commit that referenced this issue Nov 2, 2023
@mvanaken
#399: Removed unused imports.
77a1b57 
And converted limitTest to a ParameterizedTest, else PMD argues that the
method does not contain any asserts...
mvanaken added a commit that referenced this issue Nov 3, 2023
@mvanaken
#399: Add test to make sure the cache is actually used in different r…
9aaca63 
…ef usages.
mvanaken added a commit that referenced this issue Nov 24, 2023
@mvanaken @jvdb
#399: It's not possible to have a non-empty immutable list with a nul…
0d2c0de 
…l as head.

Co-authored-by: jvdb <jeroen@infix.ai>
mvanaken added a commit that referenced this issue Nov 24, 2023
@mvanaken
Merge pull request #401 from parsingdata/#399_parsevaluecache
16f7df2 
#399 Introducing ParseValueCache.
@mvanaken mvanaken added this to the 10.0.0 milestone Feb 6, 2024
@rdvdijk rdvdijk mentioned this issue Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

#399 Introducing ParseValueCache. parsingdata/metal
2 participants
@rdvdijk @mvanaken