#367 Use scope of environment for ParseValue in Until instead of the direct name. #368
Conversation
There was a problem hiding this comment.
Kind of mindblowing that the original implementation of Until just completely threw away the scope's name an inserted its own short name instead.
The tests clearly illustrate that the current workings of Until are not really in line with the general ideas we normally espouse around how combinators and values should interact in Metal. You can see this in UntilTest: the name "struct.value.terminator" doesn't make sense (the terminator is not part of the value!) but it's a result of the fact that Until acts as both a combinator (putting its name in the enclosing scope) and a value definition (putting its name on the parsed value).
| @@ -127,4 +128,16 @@ private Token createToken(final ValueExpression initialSize, final Token termina | |||
| return repn(until("line", initialSize, terminator), con(3)); | |||
| } | |||
|
|
|||
| @Test | |||
| public void nameScope() { | |||
|
Ran code coverage Jacoco locally, and everything was 100%. This codecov hickup will be resolved in #362. |
Due to this bug you are unable to select a specific value from the
ParseGraphin an other structure.Included a test, which failed without the fix.
Resolves #367