Skip to content

Commit

Permalink
Fix test thresholds
Browse files Browse the repository at this point in the history
  • Loading branch information
pgrete committed Oct 6, 2023
1 parent 6e0151e commit 98f2f1f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions inputs/diffusion.in
Original file line number Diff line number Diff line change
Expand Up @@ -60,17 +60,17 @@ reconstruction = dc
gamma = 2.0

<diffusion>
integrator = unsplit
integrator = rkl2
conduction = anisotropic
conduction_coeff = fixed
thermal_diff_coeff_code = 0.01
viscosity = none # none (disabled), isotropic, or anisotropic
viscosity_coeff = fixed
mom_diff_coeff_code = 0.25
resistivity = isotropic # none (disabled) or isotropic
resistivity = none # none (disabled) or isotropic
resistivity_coeff = fixed
ohm_diff_coeff_code = 0.25
rkl2_max_dt_ratio = 400.0
rkl2_max_dt_ratio = 100.0

<parthenon/output0>
file_type = hdf5
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@

class TestCase(utils.test_case.TestCaseAbs):
def Prepare(self, parameters, step):

assert parameters.num_ranks <= 4, "Use <= 4 ranks for diffusion test."

# 2D reference case again
Expand Down Expand Up @@ -88,6 +87,7 @@ def Prepare(self, parameters, step):
"parthenon/time/tlim=200.0",
"parthenon/output0/dt=200.0",
f"parthenon/output0/id={step}",
"diffusion/integrator=unsplit",
]

return parameters
Expand Down
4 changes: 2 additions & 2 deletions tst/regression/test_suites/diffusion/diffusion.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,10 @@ def get_ref(x):
# For a more reasonable test (which would take longer), reduce the RKL2 ratio to,
# say, 200 and extend the resolution grid to 1024 (as the first data point at N=128
# is comparatively worse than at N>128).
if conv_measured > -1.98:
if conv_measured > -1.95:
print(
f"!!!\nConvergence for test with {int_cfg} integrator "
f"is worse ({conv_measured}) than expected (-1.98).\n!!!"
f"is worse ({conv_measured}) than expected (-1.95).\n!!!"
)
tests_passed = False
p[-1, j].plot(
Expand Down

0 comments on commit 98f2f1f

Please sign in to comment.