Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Hydrodynamic Clusters #92

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Fixes for Hydrodynamic Clusters #92

merged 4 commits into from
Jan 23, 2024

Conversation

forrestglines
Copy link
Contributor

Fixes in cluster_clips.cpp to re-enable hydrodynamic simulations with fluid==euler.

Also disables the assert in the AGN feedback to check that kinetic jet injection always increased the temperature.

@forrestglines
Copy link
Contributor Author

@par-hermes format

pgrete
pgrete approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@pgrete pgrete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just going through our backlog. We've been running with this for quite some time so this works as expected.

@pgrete pgrete enabled auto-merge (squash) January 23, 2024 09:25
@pgrete pgrete disabled auto-merge January 23, 2024 09:25
@pgrete
Copy link
Contributor

pgrete commented Jan 23, 2024

I'm force merging as the timeout was related to the CI machine (and given the lack of the workflow_dispatch tag, I cannot manually retrigger this one at the moment).

@pgrete pgrete merged commit 89fa9ce into main Jan 23, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgrete pgrete pgrete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forrestglines @pgrete