-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Electron2 Support #2844
base: develop
Are you sure you want to change the base?
Adds Electron2 Support #2844
Conversation
CHECK(hal_gpio_configure(BGDTR, &conf, nullptr)); | ||
} | ||
|
||
#if HAL_PLATFORM_CELLULAR_MODEM_VOLTAGE_TRANSLATOR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work for other platforms such as M SoM? BUFEN
is not defined there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I flipped the default for HAL_PLATFORM_CELLULAR_MODEM_VINT_INVERTED
to be 1, and HAL_PLATFORM_CELLULAR_MODEM_VOLTAGE_TRANSLATOR
to be 1, and made sure electron/hal_platform_config.h
contains overrides to 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@technobly This is still broken e.g. on M SoM:
/home/avtolstoy/dev/device-os-2/modules/msom/system-part1/makefile /home/avtolstoy/dev/device-os-2/modules/msom/user-part/makefile
In file included from ./src/rtl872x/gsm0710muxer/platform.h:24,
from ../gsm0710muxer/gsm0710muxer/include/gsm0710muxer/muxer.h:25,
from ./src/rtl872x/gsm0710muxer/channel_stream.h:21,
from network/ncp_client/quectel/quectel_ncp_client.h:28,
from network/ncp_client/quectel/quectel_ncp_client.cpp:22:
network/ncp_client/quectel/quectel_ncp_client.cpp: In member function 'int particle::QuectelNcpClient::modemInit() const':
network/ncp_client/quectel/quectel_ncp_client.cpp:2027:30: error: 'BUFEN' was not declared in this scope
2027 | CHECK(hal_gpio_configure(BUFEN, &conf, nullptr));
None of the existing platforms that use Quectel NCP client have BUFEN
. IMO HAL_PLATFORM_CELLULAR_MODEM_VOLTAGE_TRANSLATOR
needs to be set by default to 0
to simplify things, and set to 1 for Boron, B SoM (both SARA) and Electron 2 (Quectel).
// NOTE: The BGVINT pin is inverted | ||
return !hal_gpio_read(BGVINT); | ||
#else | ||
return hal_gpio_read(BGVINT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will also break other platforms that use Quectel NCP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I flipped the default for HAL_PLATFORM_CELLULAR_MODEM_VINT_INVERTED
to be 1, and HAL_PLATFORM_CELLULAR_MODEM_VOLTAGE_TRANSLATOR
to be 1, and made sure electron/hal_platform_config.h
contains overrides to 0.
8b7146f
to
379d059
Compare
379d059
to
99980ce
Compare
Feature
electron2
Steps to Test
References