Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: all modules and example and docs should pass pre commit lint #26

Merged
merged 6 commits into from
Feb 25, 2021

Conversation

ArchiFleKs
Copy link
Member

No description provided.

Signed-off-by: Kevin Lefevre <lefevre.kevin@gmail.com>
Signed-off-by: Kevin Lefevre <lefevre.kevin@gmail.com>
Signed-off-by: Kevin Lefevre <lefevre.kevin@gmail.com>
Signed-off-by: Kevin Lefevre <lefevre.kevin@gmail.com>
Signed-off-by: Kevin Lefevre <lefevre.kevin@gmail.com>
Signed-off-by: Kevin Lefevre <lefevre.kevin@gmail.com>
@ArchiFleKs ArchiFleKs requested a review from rguichard February 25, 2021 17:45
@ArchiFleKs
Copy link
Member Author

I'd like to merge this before any other PR @rguichard

Copy link
Member

@rguichard rguichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ArchiFleKs ArchiFleKs merged commit f7bc99a into main Feb 25, 2021
@ArchiFleKs ArchiFleKs deleted the feat/ci-pre-external-PR branch February 25, 2021 18:02
@github-actions
Copy link

🎉 This PR is included in version 1.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

rguichard pushed a commit that referenced this pull request Mar 1, 2021
* chore: add pre-commmit check

Signed-off-by: Kevin Lefevre <lefevre.kevin@gmail.com>

* chore: update workflow

Signed-off-by: Kevin Lefevre <lefevre.kevin@gmail.com>

* chore: update mergify

Signed-off-by: Kevin Lefevre <lefevre.kevin@gmail.com>

* fix: examples should pass validation

Signed-off-by: Kevin Lefevre <lefevre.kevin@gmail.com>

* chore: update latest docs

Signed-off-by: Kevin Lefevre <lefevre.kevin@gmail.com>

* chore: add pre commit README

Signed-off-by: Kevin Lefevre <lefevre.kevin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants