Switched from MATCH-as-FROM-source to MATCH-as-expression #797

vgapeyev · 2022-09-23T16:53:08Z

Description

In a graph query like

    SELECT * FROM MyGraph MATCH (a)-[b]-(c)

the construct involving MATCH, instead of being understood as a special kind of a FROM source,
is now understood as a new expression form.
That is, MyGraph MATCH (a)-[b]-(c) is an expression that, given a graph-yielding expression and a graph pattern, produces a bag of structs (a "table") with attributes a, b, c.

With this change, a MATCH expression can be a source in a FROM clause, as any other table-producing expression. This happens to give variable-binding behavior that is different than under the earlier MATCH design. In particular, it is possible to write

     SELECT x.* FROM MyGraph MATCH (a)-[b]-(c) AS x

which produces a table with columns a, b, c.

Only the ANTLR-based parser is properly supported in this PR.
The old SqlParser got minimal changes to make it compile and still contains most of the earlier code for the original design of MATCH. However, SqlParser now breaks when given MATCH-containing source, because the target PIG AST has changed.
Please advise whether it is worth bringing SqlParser up to date.

There are a few code comments marked with PR-COMMENT. These highlight spots worthy of attention and are meant to be either removed or converted to regular comments prior to merging.

Other Information

Updated Unreleased Section in CHANGELOG: [YES]
- Modified the earlier entry about the experimental graph query feature.
Any backward-incompatible changes? [NO]
- The version-controlled behavior does change in a breaking way w.r.t. to prior commits, but they have not yet been released and the overall graph feature is experimental anyway.
Any new external dependencies? [NO]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…gpmlPattern in the grammar. The new name is a tad more appropriate for the node's contents and will be clashing less with the upcoming new expression form graph_match.

Resolved a conflict in lang/src/org/partiql/lang/eval/physical/PhysicalPlanCompilerImpl.kt

…tern with commas. Instead, require commas around the whole MATCH expression in this case.

This reverts commit af6f6c3. It's hard or impossible to match this grammar addition in the partiql-lang-rust edition of the grammar.

adjusting the success status as appropriate.

codecov-commenter · 2022-10-11T21:29:09Z

Codecov Report

Base: 81.32% // Head: 79.67% // Decreases project coverage by -1.64% ⚠️

Coverage data is based on head (0dfc9ec) compared to base (a9e5a4e).
Patch coverage: 88.46% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #797      +/-   ##
============================================
- Coverage     81.32%   79.67%   -1.65%     
- Complexity     2646     2920     +274     
============================================
  Files           262      262              
  Lines         21484    22724    +1240     
  Branches       3895     4285     +390     
============================================
+ Hits          17472    18106     +634     
- Misses         2781     3434     +653     
+ Partials       1231     1184      -47

Flag	Coverage Δ
CLI	`22.56% <ø> (ø)`
EXAMPLES	`78.63% <ø> (ø)`
EXTENSIONS	`69.23% <ø> (ø)`
LANG	`81.27% <88.46%> (-1.91%)`	⬇️
PARTIQL_PTS	`∅ <ø> (∅)`
PARTIQL_TEST_SCRIPT	`80.90% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../visitors/GroupByPathExpressionVisitorTransform.kt	`80.76% <ø> (+3.26%)`	⬆️
...planner/transforms/AstToLogicalVisitorTransform.kt	`82.21% <ø> (+0.39%)`	⬆️
...c/org/partiql/lang/prettyprint/ASTPrettyPrinter.kt	`80.77% <0.00%> (-0.19%)`	⬇️
lang/src/org/partiql/lang/syntax/SqlParser.kt	`63.38% <0.00%> (-14.83%)`	⬇️
...ng/src/org/partiql/lang/ast/StatementToExprNode.kt	`89.83% <100.00%> (+0.56%)`	⬆️
...ng/src/org/partiql/lang/eval/EvaluatingCompiler.kt	`82.92% <100.00%> (+2.64%)`	⬆️
...iql/lang/eval/physical/PhysicalPlanCompilerImpl.kt	`83.62% <100.00%> (-0.13%)`	⬇️
...ng/src/org/partiql/lang/visitors/PartiQLVisitor.kt	`94.24% <100.00%> (+3.15%)`	⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

jpschorr · 2022-10-12T16:59:38Z

lang/src/org/partiql/lang/prettyprint/ASTPrettyPrinter.kt

@@ -557,6 +557,8 @@ class ASTPrettyPrinter {
                    if (node.offset == null) it else (it.plusElement(toRecursionTree(node.offset, "offset")))
                }
            )
+            // PR-COMMENT This is on par with the TODO that was in toRecursionTree(PartiqlAst.FromSource) overload.


Can remove the PR-COMMENT line

commit 05c1785 Author: lziq <67429381+lziq@users.noreply.github.com> Date: Wed Oct 19 10:11:34 2022 -0700 Applied comments in PR 822 (#836) commit 8255a07 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Tue Oct 18 14:15:15 2022 -0700 Set next dev version (#846) commit bc4dc47 Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Tue Oct 18 13:13:53 2022 -0700 Bumps partiql-isl-kotlin to 0.2.2 (#845) commit 55de098 Author: Alan Cai <caialan@amazon.com> Date: Mon Oct 17 14:01:40 2022 -0700 Update conformance test runner skip list with ported `pts` tests (#829) commit d8bcf1f Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Mon Oct 17 09:15:21 2022 -0700 v0.8.0 (#844) Creates 0.8.0 commit commit b4b7e1f Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Fri Oct 14 16:52:49 2022 -0700 Moves partiql-grammar to org.partiql.lang.syntax.antlr so we don't vend a separate jar (#843) commit 28d960f Author: yliuuuu <107505258+yliuuuu@users.noreply.github.com> Date: Thu Oct 13 16:07:57 2022 -0700 fix subquery execution (#842) commit 0b8d14a Author: Arash Maymandi <27716912+am357@users.noreply.github.com> Date: Thu Oct 13 16:04:55 2022 -0700 Final changes for REPLACE/UPSERT/INSERT EXCLUDED (#831) This commit includes the following: - Support for INSERT INTO tbl ... ON CONFLICT DO REPLACE EXCLUDED and REPLACE INTO tbl ... evaluation. - Support for INSERT INTO tbl ... ON CONFLICT DO UPDATE EXCLUDED logical planning. - The reason that evaluation is excluded is b/c the logic is for update evaluation requires implementing merge with existing values which makes it more completed; since it's not part of the related ask (attached issue) we defer the implementation for now - Adds parsing support for AS alias for UPSERT INTO and REPLACE INTO statements. commit 13f622f Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 13 15:50:06 2022 -0700 Cleans up SORT and UNPIVOT factories (#839) commit 17acf86 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 13 15:47:41 2022 -0700 Updates changelog (#840) commit 376bc18 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 13 14:45:45 2022 -0700 Adds support for aggregations and grouping to the planner (#821) commit 8be7a2d Author: Alan Cai <caialan@amazon.com> Date: Wed Oct 12 13:37:59 2022 -0700 Update README.md following addition of partiql-tests git submodule (#838) commit 2210658 Merge: 5715a88 9fdc92c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Wed Oct 12 10:40:25 2022 -0700 Merge pull request #797 from partiql/graph-match-expr Switched from MATCH-as-FROM-source to MATCH-as-expression commit 9fdc92c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Wed Oct 12 10:36:39 2022 -0700 Cleanup commit 0dfc9ec Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 11 14:09:36 2022 -0700 Put back tests from the reverted commit, adjusting the success status as appropriate. commit a7b42bf Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 11 10:58:32 2022 -0700 Revert "Allow unparethesized MATCH in more places." This reverts commit af6f6c3. It's hard or impossible to match this grammar addition in the partiql-lang-rust edition of the grammar. commit 5715a88 Author: Josh Pschorr <josh@pschorr.dev> Date: Fri Oct 7 13:41:00 2022 -0700 Default sort & null spec in evaluator, not parser (#834) commit af6f6c3 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Thu Oct 6 23:11:09 2022 -0700 Allow unparethesized MATCH in more places. commit 9b26e9c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Thu Oct 6 16:00:58 2022 -0700 Grammar tweaks to not require (and prohibit) parentheses around a pattern with commas. Instead, require commas around the whole MATCH expression in this case. commit 1ce2669 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 4 22:49:22 2022 -0700 A couple more parsing tests, involving a bare edge pattern -[]->. commit e552b92 Merge: 02b07cb a9e5a4e Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 4 17:36:45 2022 -0700 Merge branch 'main' into graph-match-expr. Resolved a conflict in lang/src/org/partiql/lang/eval/physical/PhysicalPlanCompilerImpl.kt commit a9e5a4e Author: lziq <67429381+lziq@users.noreply.github.com> Date: Tue Oct 4 15:32:00 2022 -0700 Removed snapshot from version (#828) commit a0209df Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Mon Oct 3 13:57:55 2022 -0700 Adds PIVOT to PartiQLPlanner (#817) commit 9a159a0 Author: yliuuuu <107505258+yliuuuu@users.noreply.github.com> Date: Mon Oct 3 10:45:01 2022 -0700 Adds UNPIVOT operator to PartiQLPlanner (#815) * support `unpivot` operator in planner commit 07f4a27 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Fri Sep 30 17:02:57 2022 -0400 Adds SORT operator to planner (#793) commit f80e015 Author: Alan Cai <caialan@amazon.com> Date: Wed Sep 28 14:26:35 2022 -0700 Add Kotlin conformance test runner (#809) commit 882d7d2 Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Tue Sep 27 17:11:55 2022 -0700 Remove state from planner (#813) commit a871ba5 Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Tue Sep 27 10:42:13 2022 -0700 Moves partiql-isl-kotlin to a library of partiql-lang-kotlin (#805) commit cd16bf3 Author: lziq <67429381+lziq@users.noreply.github.com> Date: Mon Sep 26 15:38:08 2022 -0700 Removed type names from ExprValueType (#808) commit 2e19331 Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Mon Sep 26 08:23:20 2022 -0700 Renames PhysicalExprToThunkConverter as PhysicalPlanCompiler (#801) commit 706acd9 Author: lziq <67429381+lziq@users.noreply.github.com> Date: Fri Sep 23 10:03:51 2022 -0700 Marked TypedOpBehavior.LEGACY as deprecated (#796) commit 02b07cb Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Fri Sep 23 09:58:05 2022 -0700 Lint fixes. commit f29f894 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Thu Sep 22 21:16:56 2022 -0700 Switched from MATCH-as-FROM-source to MATCH-as-expression. commit 4b3ec94 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Sun Sep 18 15:34:08 2022 -0700 Rename AST node graph_match_expr ~~> gpml_pattern, and matchExpr ~~> gpmlPattern in the grammar. The new name is a tad more appropriate for the node's contents and will be clashing less with the upcoming new expression form graph_match. commit 58e908d Author: Arash Maymandi <27716912+am357@users.noreply.github.com> Date: Thu Sep 22 15:32:20 2022 -0700 Add experimental REPLACE/UPSERT INTO (#788) * Add experimental REPLACE/UPSERT INTO Adding the parsing capability for `REPLACE INTO` and `REPLACE INTO`. See the PR and associated Issue for more details. commit 8bfaf20 Author: Arash Maymandi <27716912+am357@users.noreply.github.com> Date: Thu Sep 22 14:38:16 2022 -0700 Add logical plan support for DO REPLACE EXCLUDED (#792) commit 96de8e7 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Wed Sep 21 14:45:58 2022 -0700 Adds projection alias support to ORDER BY clause (#740) * Adds projection alias support to ORDER BY clause commit 001a99b Author: Arash Maymandi <27716912+am357@users.noreply.github.com> Date: Wed Sep 21 12:59:42 2022 -0700 Add an additional example for ExprFunction (#786) * Add an additional example for ExprFunction Adds an example for using a custom function for working with elements of lists and struct members. commit 58dd2cb Author: lziq <67429381+lziq@users.noreply.github.com> Date: Tue Sep 20 15:23:10 2022 -0700 Refactor stivt code (#791) commit 74b6cf6 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Mon Sep 19 10:49:12 2022 -0700 Splits large tests to allow parallelization and speedup in builds (#779) commit 16ccbc1 Author: lziq <67429381+lziq@users.noreply.github.com> Date: Fri Sep 16 09:52:18 2022 -0700 Refactor STIVT Code Style (#782)

commit ebbe6dc Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 20 14:01:00 2022 -0700 Update ISL to SNAPSHOT (#851) commit a298d93 Author: Arash Maymandi <27716912+am357@users.noreply.github.com> Date: Thu Oct 20 12:13:52 2022 -0700 Add redaction for INSERT/UPSERT/REPLACE INTO << >> (#850) This commit enables statement redaction for INSERT, REPLACE, and UPSERT. See the following for more details: #849 commit fb4b29f Merge: 05c1785 8f8d6d9 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Thu Oct 20 10:31:39 2022 -0700 Merge pull request #847 from partiql/issue-616 Makes SqlException.errorContext non-nullable, resolving Issue #616. commit 8f8d6d9 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Wed Oct 19 11:32:54 2022 -0700 Attempting to fix divergence in the git submodule test/partiql-tests. commit 05c1785 Author: lziq <67429381+lziq@users.noreply.github.com> Date: Wed Oct 19 10:11:34 2022 -0700 Applied comments in PR 822 (#836) commit 89dacc2 Merge: 7ab757c 8255a07 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 18 17:17:22 2022 -0700 Merge branch 'main' into issue-616 commit 8255a07 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Tue Oct 18 14:15:15 2022 -0700 Set next dev version (#846) commit 7ab757c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 18 13:14:43 2022 -0700 Makes SqlException.errorContext non-nullable, resolving Issue #616. commit bc4dc47 Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Tue Oct 18 13:13:53 2022 -0700 Bumps partiql-isl-kotlin to 0.2.2 (#845) commit 55de098 Author: Alan Cai <caialan@amazon.com> Date: Mon Oct 17 14:01:40 2022 -0700 Update conformance test runner skip list with ported `pts` tests (#829) commit d8bcf1f Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Mon Oct 17 09:15:21 2022 -0700 v0.8.0 (#844) Creates 0.8.0 commit commit b4b7e1f Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Fri Oct 14 16:52:49 2022 -0700 Moves partiql-grammar to org.partiql.lang.syntax.antlr so we don't vend a separate jar (#843) commit 28d960f Author: yliuuuu <107505258+yliuuuu@users.noreply.github.com> Date: Thu Oct 13 16:07:57 2022 -0700 fix subquery execution (#842) commit 0b8d14a Author: Arash Maymandi <27716912+am357@users.noreply.github.com> Date: Thu Oct 13 16:04:55 2022 -0700 Final changes for REPLACE/UPSERT/INSERT EXCLUDED (#831) This commit includes the following: - Support for INSERT INTO tbl ... ON CONFLICT DO REPLACE EXCLUDED and REPLACE INTO tbl ... evaluation. - Support for INSERT INTO tbl ... ON CONFLICT DO UPDATE EXCLUDED logical planning. - The reason that evaluation is excluded is b/c the logic is for update evaluation requires implementing merge with existing values which makes it more completed; since it's not part of the related ask (attached issue) we defer the implementation for now - Adds parsing support for AS alias for UPSERT INTO and REPLACE INTO statements. commit 13f622f Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 13 15:50:06 2022 -0700 Cleans up SORT and UNPIVOT factories (#839) commit 17acf86 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 13 15:47:41 2022 -0700 Updates changelog (#840) commit 376bc18 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 13 14:45:45 2022 -0700 Adds support for aggregations and grouping to the planner (#821) commit 8be7a2d Author: Alan Cai <caialan@amazon.com> Date: Wed Oct 12 13:37:59 2022 -0700 Update README.md following addition of partiql-tests git submodule (#838) commit 2210658 Merge: 5715a88 9fdc92c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Wed Oct 12 10:40:25 2022 -0700 Merge pull request #797 from partiql/graph-match-expr Switched from MATCH-as-FROM-source to MATCH-as-expression commit 9fdc92c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Wed Oct 12 10:36:39 2022 -0700 Cleanup commit 0dfc9ec Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 11 14:09:36 2022 -0700 Put back tests from the reverted commit, adjusting the success status as appropriate. commit a7b42bf Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 11 10:58:32 2022 -0700 Revert "Allow unparethesized MATCH in more places." This reverts commit af6f6c3. It's hard or impossible to match this grammar addition in the partiql-lang-rust edition of the grammar. commit 5715a88 Author: Josh Pschorr <josh@pschorr.dev> Date: Fri Oct 7 13:41:00 2022 -0700 Default sort & null spec in evaluator, not parser (#834) commit af6f6c3 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Thu Oct 6 23:11:09 2022 -0700 Allow unparethesized MATCH in more places. commit 9b26e9c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Thu Oct 6 16:00:58 2022 -0700 Grammar tweaks to not require (and prohibit) parentheses around a pattern with commas. Instead, require commas around the whole MATCH expression in this case. commit 1ce2669 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 4 22:49:22 2022 -0700 A couple more parsing tests, involving a bare edge pattern -[]->. commit e552b92 Merge: 02b07cb a9e5a4e Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 4 17:36:45 2022 -0700 Merge branch 'main' into graph-match-expr. Resolved a conflict in lang/src/org/partiql/lang/eval/physical/PhysicalPlanCompilerImpl.kt commit a9e5a4e Author: lziq <67429381+lziq@users.noreply.github.com> Date: Tue Oct 4 15:32:00 2022 -0700 Removed snapshot from version (#828) commit a0209df Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Mon Oct 3 13:57:55 2022 -0700 Adds PIVOT to PartiQLPlanner (#817) commit 9a159a0 Author: yliuuuu <107505258+yliuuuu@users.noreply.github.com> Date: Mon Oct 3 10:45:01 2022 -0700 Adds UNPIVOT operator to PartiQLPlanner (#815) * support `unpivot` operator in planner commit 07f4a27 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Fri Sep 30 17:02:57 2022 -0400 Adds SORT operator to planner (#793) commit f80e015 Author: Alan Cai <caialan@amazon.com> Date: Wed Sep 28 14:26:35 2022 -0700 Add Kotlin conformance test runner (#809) commit 882d7d2 Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Tue Sep 27 17:11:55 2022 -0700 Remove state from planner (#813) commit a871ba5 Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Tue Sep 27 10:42:13 2022 -0700 Moves partiql-isl-kotlin to a library of partiql-lang-kotlin (#805) commit cd16bf3 Author: lziq <67429381+lziq@users.noreply.github.com> Date: Mon Sep 26 15:38:08 2022 -0700 Removed type names from ExprValueType (#808) commit 2e19331 Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Mon Sep 26 08:23:20 2022 -0700 Renames PhysicalExprToThunkConverter as PhysicalPlanCompiler (#801) commit 706acd9 Author: lziq <67429381+lziq@users.noreply.github.com> Date: Fri Sep 23 10:03:51 2022 -0700 Marked TypedOpBehavior.LEGACY as deprecated (#796) commit 02b07cb Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Fri Sep 23 09:58:05 2022 -0700 Lint fixes. commit f29f894 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Thu Sep 22 21:16:56 2022 -0700 Switched from MATCH-as-FROM-source to MATCH-as-expression. commit 4b3ec94 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Sun Sep 18 15:34:08 2022 -0700 Rename AST node graph_match_expr ~~> gpml_pattern, and matchExpr ~~> gpmlPattern in the grammar. The new name is a tad more appropriate for the node's contents and will be clashing less with the upcoming new expression form graph_match. commit 58e908d Author: Arash Maymandi <27716912+am357@users.noreply.github.com> Date: Thu Sep 22 15:32:20 2022 -0700 Add experimental REPLACE/UPSERT INTO (#788) * Add experimental REPLACE/UPSERT INTO Adding the parsing capability for `REPLACE INTO` and `REPLACE INTO`. See the PR and associated Issue for more details. commit 8bfaf20 Author: Arash Maymandi <27716912+am357@users.noreply.github.com> Date: Thu Sep 22 14:38:16 2022 -0700 Add logical plan support for DO REPLACE EXCLUDED (#792) commit 96de8e7 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Wed Sep 21 14:45:58 2022 -0700 Adds projection alias support to ORDER BY clause (#740) * Adds projection alias support to ORDER BY clause commit 001a99b Author: Arash Maymandi <27716912+am357@users.noreply.github.com> Date: Wed Sep 21 12:59:42 2022 -0700 Add an additional example for ExprFunction (#786) * Add an additional example for ExprFunction Adds an example for using a custom function for working with elements of lists and struct members. commit 58dd2cb Author: lziq <67429381+lziq@users.noreply.github.com> Date: Tue Sep 20 15:23:10 2022 -0700 Refactor stivt code (#791) commit 74b6cf6 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Mon Sep 19 10:49:12 2022 -0700 Splits large tests to allow parallelization and speedup in builds (#779) commit 16ccbc1 Author: lziq <67429381+lziq@users.noreply.github.com> Date: Fri Sep 16 09:52:18 2022 -0700 Refactor STIVT Code Style (#782)

commit c272f1b Merge: d667635 aa199ef Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Mon Oct 31 16:19:19 2022 -0700 Merge pull request #861 from partiql/v0.8.1 Branching for 0.8.1 release. commit aa199ef Merge: 025347c d667635 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Mon Oct 31 16:12:16 2022 -0700 Merge branch 'main' into v0.8.1 Resolved conflicts in CHANGELOG.md commit d667635 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Mon Oct 31 13:25:12 2022 -0700 Adds simple auto-completion to the CLI (#855) commit 025347c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Fri Oct 28 22:02:53 2022 +0000 We do have to release partiql-isl-kotlin alongside partiql-lang-kotlin, after all. Otherwise, release to Maven does not work out with the current nested-project setup. commit 7cc25a4 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Fri Oct 28 11:12:29 2022 -0700 Revert ISL release. commit d003273 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Fri Oct 28 08:47:49 2022 -0700 Branching for 0.8.1 release. commit a4c20f2 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 27 15:41:32 2022 -0700 Updates the CLI Shell Highlighter to use ANTLR-generated lexer/parser (#854) commit ab88148 Author: Alan Cai <caialan@amazon.com> Date: Thu Oct 27 12:55:10 2022 -0700 Add `partiql-lang-kotlin` version migration modules (#852) commit cce34d2 Author: lziq <67429381+lziq@users.noreply.github.com> Date: Mon Oct 24 15:51:39 2022 -0700 Set `TypedOpParameter` to be `HONOR_PARAMETER` by default (#783) commit ebbe6dc Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 20 14:01:00 2022 -0700 Update ISL to SNAPSHOT (#851) commit a298d93 Author: Arash Maymandi <27716912+am357@users.noreply.github.com> Date: Thu Oct 20 12:13:52 2022 -0700 Add redaction for INSERT/UPSERT/REPLACE INTO << >> (#850) This commit enables statement redaction for INSERT, REPLACE, and UPSERT. See the following for more details: #849 commit fb4b29f Merge: 05c1785 8f8d6d9 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Thu Oct 20 10:31:39 2022 -0700 Merge pull request #847 from partiql/issue-616 Makes SqlException.errorContext non-nullable, resolving Issue #616. commit 8f8d6d9 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Wed Oct 19 11:32:54 2022 -0700 Attempting to fix divergence in the git submodule test/partiql-tests. commit 05c1785 Author: lziq <67429381+lziq@users.noreply.github.com> Date: Wed Oct 19 10:11:34 2022 -0700 Applied comments in PR 822 (#836) commit 89dacc2 Merge: 7ab757c 8255a07 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 18 17:17:22 2022 -0700 Merge branch 'main' into issue-616 commit 8255a07 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Tue Oct 18 14:15:15 2022 -0700 Set next dev version (#846) commit 7ab757c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 18 13:14:43 2022 -0700 Makes SqlException.errorContext non-nullable, resolving Issue #616. commit bc4dc47 Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Tue Oct 18 13:13:53 2022 -0700 Bumps partiql-isl-kotlin to 0.2.2 (#845) commit 55de098 Author: Alan Cai <caialan@amazon.com> Date: Mon Oct 17 14:01:40 2022 -0700 Update conformance test runner skip list with ported `pts` tests (#829) commit d8bcf1f Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Mon Oct 17 09:15:21 2022 -0700 v0.8.0 (#844) Creates 0.8.0 commit commit b4b7e1f Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Fri Oct 14 16:52:49 2022 -0700 Moves partiql-grammar to org.partiql.lang.syntax.antlr so we don't vend a separate jar (#843) commit 28d960f Author: yliuuuu <107505258+yliuuuu@users.noreply.github.com> Date: Thu Oct 13 16:07:57 2022 -0700 fix subquery execution (#842) commit 0b8d14a Author: Arash Maymandi <27716912+am357@users.noreply.github.com> Date: Thu Oct 13 16:04:55 2022 -0700 Final changes for REPLACE/UPSERT/INSERT EXCLUDED (#831) This commit includes the following: - Support for INSERT INTO tbl ... ON CONFLICT DO REPLACE EXCLUDED and REPLACE INTO tbl ... evaluation. - Support for INSERT INTO tbl ... ON CONFLICT DO UPDATE EXCLUDED logical planning. - The reason that evaluation is excluded is b/c the logic is for update evaluation requires implementing merge with existing values which makes it more completed; since it's not part of the related ask (attached issue) we defer the implementation for now - Adds parsing support for AS alias for UPSERT INTO and REPLACE INTO statements. commit 13f622f Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 13 15:50:06 2022 -0700 Cleans up SORT and UNPIVOT factories (#839) commit 17acf86 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 13 15:47:41 2022 -0700 Updates changelog (#840) commit 376bc18 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 13 14:45:45 2022 -0700 Adds support for aggregations and grouping to the planner (#821) commit 8be7a2d Author: Alan Cai <caialan@amazon.com> Date: Wed Oct 12 13:37:59 2022 -0700 Update README.md following addition of partiql-tests git submodule (#838) commit 2210658 Merge: 5715a88 9fdc92c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Wed Oct 12 10:40:25 2022 -0700 Merge pull request #797 from partiql/graph-match-expr Switched from MATCH-as-FROM-source to MATCH-as-expression commit 9fdc92c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Wed Oct 12 10:36:39 2022 -0700 Cleanup commit 0dfc9ec Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 11 14:09:36 2022 -0700 Put back tests from the reverted commit, adjusting the success status as appropriate. commit a7b42bf Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 11 10:58:32 2022 -0700 Revert "Allow unparethesized MATCH in more places." This reverts commit af6f6c3. It's hard or impossible to match this grammar addition in the partiql-lang-rust edition of the grammar. commit 5715a88 Author: Josh Pschorr <josh@pschorr.dev> Date: Fri Oct 7 13:41:00 2022 -0700 Default sort & null spec in evaluator, not parser (#834) commit af6f6c3 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Thu Oct 6 23:11:09 2022 -0700 Allow unparethesized MATCH in more places. commit 9b26e9c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Thu Oct 6 16:00:58 2022 -0700 Grammar tweaks to not require (and prohibit) parentheses around a pattern with commas. Instead, require commas around the whole MATCH expression in this case. commit 1ce2669 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 4 22:49:22 2022 -0700 A couple more parsing tests, involving a bare edge pattern -[]->. commit e552b92 Merge: 02b07cb a9e5a4e Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 4 17:36:45 2022 -0700 Merge branch 'main' into graph-match-expr. Resolved a conflict in lang/src/org/partiql/lang/eval/physical/PhysicalPlanCompilerImpl.kt commit a9e5a4e Author: lziq <67429381+lziq@users.noreply.github.com> Date: Tue Oct 4 15:32:00 2022 -0700 Removed snapshot from version (#828) commit a0209df Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Mon Oct 3 13:57:55 2022 -0700 Adds PIVOT to PartiQLPlanner (#817) commit 9a159a0 Author: yliuuuu <107505258+yliuuuu@users.noreply.github.com> Date: Mon Oct 3 10:45:01 2022 -0700 Adds UNPIVOT operator to PartiQLPlanner (#815) * support `unpivot` operator in planner commit 07f4a27 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Fri Sep 30 17:02:57 2022 -0400 Adds SORT operator to planner (#793) commit 02b07cb Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Fri Sep 23 09:58:05 2022 -0700 Lint fixes. commit f29f894 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Thu Sep 22 21:16:56 2022 -0700 Switched from MATCH-as-FROM-source to MATCH-as-expression. commit 4b3ec94 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Sun Sep 18 15:34:08 2022 -0700 Rename AST node graph_match_expr ~~> gpml_pattern, and matchExpr ~~> gpmlPattern in the grammar. The new name is a tad more appropriate for the node's contents and will be clashing less with the upcoming new expression form graph_match.

commit 2c08d17 Author: Ziqi Li <lziq@amazon.com> Date: Mon Oct 31 19:50:30 2022 -0700 Squashed commit of the following: commit c272f1b Merge: d667635 aa199ef Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Mon Oct 31 16:19:19 2022 -0700 Merge pull request #861 from partiql/v0.8.1 Branching for 0.8.1 release. commit aa199ef Merge: 025347c d667635 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Mon Oct 31 16:12:16 2022 -0700 Merge branch 'main' into v0.8.1 Resolved conflicts in CHANGELOG.md commit d667635 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Mon Oct 31 13:25:12 2022 -0700 Adds simple auto-completion to the CLI (#855) commit 025347c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Fri Oct 28 22:02:53 2022 +0000 We do have to release partiql-isl-kotlin alongside partiql-lang-kotlin, after all. Otherwise, release to Maven does not work out with the current nested-project setup. commit 7cc25a4 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Fri Oct 28 11:12:29 2022 -0700 Revert ISL release. commit d003273 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Fri Oct 28 08:47:49 2022 -0700 Branching for 0.8.1 release. commit a4c20f2 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 27 15:41:32 2022 -0700 Updates the CLI Shell Highlighter to use ANTLR-generated lexer/parser (#854) commit ab88148 Author: Alan Cai <caialan@amazon.com> Date: Thu Oct 27 12:55:10 2022 -0700 Add `partiql-lang-kotlin` version migration modules (#852) commit cce34d2 Author: lziq <67429381+lziq@users.noreply.github.com> Date: Mon Oct 24 15:51:39 2022 -0700 Set `TypedOpParameter` to be `HONOR_PARAMETER` by default (#783) commit ebbe6dc Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 20 14:01:00 2022 -0700 Update ISL to SNAPSHOT (#851) commit a298d93 Author: Arash Maymandi <27716912+am357@users.noreply.github.com> Date: Thu Oct 20 12:13:52 2022 -0700 Add redaction for INSERT/UPSERT/REPLACE INTO << >> (#850) This commit enables statement redaction for INSERT, REPLACE, and UPSERT. See the following for more details: #849 commit fb4b29f Merge: 05c1785 8f8d6d9 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Thu Oct 20 10:31:39 2022 -0700 Merge pull request #847 from partiql/issue-616 Makes SqlException.errorContext non-nullable, resolving Issue #616. commit 8f8d6d9 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Wed Oct 19 11:32:54 2022 -0700 Attempting to fix divergence in the git submodule test/partiql-tests. commit 05c1785 Author: lziq <67429381+lziq@users.noreply.github.com> Date: Wed Oct 19 10:11:34 2022 -0700 Applied comments in PR 822 (#836) commit 89dacc2 Merge: 7ab757c 8255a07 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 18 17:17:22 2022 -0700 Merge branch 'main' into issue-616 commit 8255a07 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Tue Oct 18 14:15:15 2022 -0700 Set next dev version (#846) commit 7ab757c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 18 13:14:43 2022 -0700 Makes SqlException.errorContext non-nullable, resolving Issue #616. commit bc4dc47 Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Tue Oct 18 13:13:53 2022 -0700 Bumps partiql-isl-kotlin to 0.2.2 (#845) commit 55de098 Author: Alan Cai <caialan@amazon.com> Date: Mon Oct 17 14:01:40 2022 -0700 Update conformance test runner skip list with ported `pts` tests (#829) commit d8bcf1f Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Mon Oct 17 09:15:21 2022 -0700 v0.8.0 (#844) Creates 0.8.0 commit commit b4b7e1f Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Fri Oct 14 16:52:49 2022 -0700 Moves partiql-grammar to org.partiql.lang.syntax.antlr so we don't vend a separate jar (#843) commit 28d960f Author: yliuuuu <107505258+yliuuuu@users.noreply.github.com> Date: Thu Oct 13 16:07:57 2022 -0700 fix subquery execution (#842) commit 0b8d14a Author: Arash Maymandi <27716912+am357@users.noreply.github.com> Date: Thu Oct 13 16:04:55 2022 -0700 Final changes for REPLACE/UPSERT/INSERT EXCLUDED (#831) This commit includes the following: - Support for INSERT INTO tbl ... ON CONFLICT DO REPLACE EXCLUDED and REPLACE INTO tbl ... evaluation. - Support for INSERT INTO tbl ... ON CONFLICT DO UPDATE EXCLUDED logical planning. - The reason that evaluation is excluded is b/c the logic is for update evaluation requires implementing merge with existing values which makes it more completed; since it's not part of the related ask (attached issue) we defer the implementation for now - Adds parsing support for AS alias for UPSERT INTO and REPLACE INTO statements. commit 13f622f Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 13 15:50:06 2022 -0700 Cleans up SORT and UNPIVOT factories (#839) commit 17acf86 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 13 15:47:41 2022 -0700 Updates changelog (#840) commit 376bc18 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Thu Oct 13 14:45:45 2022 -0700 Adds support for aggregations and grouping to the planner (#821) commit 8be7a2d Author: Alan Cai <caialan@amazon.com> Date: Wed Oct 12 13:37:59 2022 -0700 Update README.md following addition of partiql-tests git submodule (#838) commit 2210658 Merge: 5715a88 9fdc92c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Wed Oct 12 10:40:25 2022 -0700 Merge pull request #797 from partiql/graph-match-expr Switched from MATCH-as-FROM-source to MATCH-as-expression commit 9fdc92c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Wed Oct 12 10:36:39 2022 -0700 Cleanup commit 0dfc9ec Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 11 14:09:36 2022 -0700 Put back tests from the reverted commit, adjusting the success status as appropriate. commit a7b42bf Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 11 10:58:32 2022 -0700 Revert "Allow unparethesized MATCH in more places." This reverts commit af6f6c3. It's hard or impossible to match this grammar addition in the partiql-lang-rust edition of the grammar. commit 5715a88 Author: Josh Pschorr <josh@pschorr.dev> Date: Fri Oct 7 13:41:00 2022 -0700 Default sort & null spec in evaluator, not parser (#834) commit af6f6c3 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Thu Oct 6 23:11:09 2022 -0700 Allow unparethesized MATCH in more places. commit 9b26e9c Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Thu Oct 6 16:00:58 2022 -0700 Grammar tweaks to not require (and prohibit) parentheses around a pattern with commas. Instead, require commas around the whole MATCH expression in this case. commit 1ce2669 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 4 22:49:22 2022 -0700 A couple more parsing tests, involving a bare edge pattern -[]->. commit e552b92 Merge: 02b07cb a9e5a4e Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Tue Oct 4 17:36:45 2022 -0700 Merge branch 'main' into graph-match-expr. Resolved a conflict in lang/src/org/partiql/lang/eval/physical/PhysicalPlanCompilerImpl.kt commit a9e5a4e Author: lziq <67429381+lziq@users.noreply.github.com> Date: Tue Oct 4 15:32:00 2022 -0700 Removed snapshot from version (#828) commit a0209df Author: R. C. Howell <RCHowell@users.noreply.github.com> Date: Mon Oct 3 13:57:55 2022 -0700 Adds PIVOT to PartiQLPlanner (#817) commit 9a159a0 Author: yliuuuu <107505258+yliuuuu@users.noreply.github.com> Date: Mon Oct 3 10:45:01 2022 -0700 Adds UNPIVOT operator to PartiQLPlanner (#815) * support `unpivot` operator in planner commit 07f4a27 Author: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Date: Fri Sep 30 17:02:57 2022 -0400 Adds SORT operator to planner (#793) commit 02b07cb Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Fri Sep 23 09:58:05 2022 -0700 Lint fixes. commit f29f894 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Thu Sep 22 21:16:56 2022 -0700 Switched from MATCH-as-FROM-source to MATCH-as-expression. commit 4b3ec94 Author: Vladimir Gapeyev <9939945+vgapeyev@users.noreply.github.com> Date: Sun Sep 18 15:34:08 2022 -0700 Rename AST node graph_match_expr ~~> gpml_pattern, and matchExpr ~~> gpmlPattern in the grammar. The new name is a tad more appropriate for the node's contents and will be clashing less with the upcoming new expression form graph_match.

vgapeyev added 3 commits September 22, 2022 21:19

Rename AST node graph_match_expr ~~> gpml_pattern, and matchExpr ~~> …

4b3ec94

…gpmlPattern in the grammar. The new name is a tad more appropriate for the node's contents and will be clashing less with the upcoming new expression form graph_match.

Switched from MATCH-as-FROM-source to MATCH-as-expression.

f29f894

Lint fixes.

02b07cb

alancai98 added this to the PartiQL v0.8.0 Release milestone Sep 23, 2022

vgapeyev requested review from johnedquinn and jpschorr September 23, 2022 17:25

vgapeyev marked this pull request as ready for review September 23, 2022 17:25

jpschorr mentioned this pull request Sep 27, 2022

Add experimental draft support for GPML-style graph query parsing partiql/partiql-lang-rust#148

Draft

vgapeyev added 4 commits October 4, 2022 17:36

Merge branch 'main' into graph-match-expr.

e552b92

Resolved a conflict in lang/src/org/partiql/lang/eval/physical/PhysicalPlanCompilerImpl.kt

A couple more parsing tests, involving a bare edge pattern -[]->.

1ce2669

Grammar tweaks to not require (and prohibit) parentheses around a pat…

9b26e9c

…tern with commas. Instead, require commas around the whole MATCH expression in this case.

Allow unparethesized MATCH in more places.

af6f6c3

alancai98 mentioned this pull request Oct 10, 2022

New Release Date? #795

Closed

vgapeyev added 2 commits October 11, 2022 10:58

Revert "Allow unparethesized MATCH in more places."

a7b42bf

This reverts commit af6f6c3. It's hard or impossible to match this grammar addition in the partiql-lang-rust edition of the grammar.

Put back tests from the reverted commit,

0dfc9ec

adjusting the success status as appropriate.

jpschorr reviewed Oct 12, 2022

View reviewed changes

jpschorr previously approved these changes Oct 12, 2022

View reviewed changes

Cleanup

9fdc92c

vgapeyev dismissed jpschorr’s stale review via 9fdc92c October 12, 2022 17:37

vgapeyev merged commit 2210658 into main Oct 12, 2022

vgapeyev deleted the graph-match-expr branch October 12, 2022 17:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switched from MATCH-as-FROM-source to MATCH-as-expression #797

Switched from MATCH-as-FROM-source to MATCH-as-expression #797

vgapeyev commented Sep 23, 2022

codecov-commenter commented Oct 11, 2022 •

edited

Loading

jpschorr Oct 12, 2022

Switched from MATCH-as-FROM-source to MATCH-as-expression #797

Switched from MATCH-as-FROM-source to MATCH-as-expression #797

Conversation

vgapeyev commented Sep 23, 2022

Description

Other Information

License Information

codecov-commenter commented Oct 11, 2022 • edited Loading

Codecov Report

jpschorr Oct 12, 2022

Choose a reason for hiding this comment

codecov-commenter commented Oct 11, 2022 •

edited

Loading